From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751091AbeAVJ7b (ORCPT ); Mon, 22 Jan 2018 04:59:31 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35450 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbeAVJ73 (ORCPT ); Mon, 22 Jan 2018 04:59:29 -0500 X-Google-Smtp-Source: AH8x225z7iV67Yw4993DwPXT2d7d33jcqFfljJLG6s5rV0f5OKGvkpdxOYUEZJ0rzaEDtPfuU4YjrQ== Date: Mon, 22 Jan 2018 18:59:25 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] printk: drop redundant devkmsg_log_str memsets Message-ID: <20180122095925.GB403@jagdpanzerIV> References: <20180119043901.1728-1-sergey.senozhatsky@gmail.com> <20180122095413.eg767yjec4qwqwyn@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180122095413.eg767yjec4qwqwyn@pathway.suse.cz> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (01/22/18 10:54), Petr Mladek wrote: > On Fri 2018-01-19 13:39:01, Sergey Senozhatsky wrote: > > We copy in null terminated strings "on" and "off", no > > need to zero out devkmsg_log_str in control_devkmsg(). > > > > Signed-off-by: Sergey Senozhatsky > > Great catch! > > Reviewed-by: Petr Mladek > > I have pushed this into for-4.16 branch in printk.git, see > https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-4.16&id=6fd78a1a99c9580da49ee8f951fdce9846256375 Thanks. -ss