From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbeAVKeR (ORCPT ); Mon, 22 Jan 2018 05:34:17 -0500 Received: from mail-wr0-f172.google.com ([209.85.128.172]:42421 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbeAVKeO (ORCPT ); Mon, 22 Jan 2018 05:34:14 -0500 X-Google-Smtp-Source: AH8x225dRAiruhReJF/jWI1WJy1l/3nALCjHkcOX2Qhj50O7caBSklo9TN5SMAfQ/8k4z3jKrH+eSg== Date: Mon, 22 Jan 2018 11:34:12 +0100 From: Jiri Pirko To: Colin King Cc: Arkadi Sharshevsky , Jiri Pirko , "David S . Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] devlink: fix memory leak on 'resource' Message-ID: <20180122103412.GB2012@nanopsycho> References: <20180122103119.4801-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180122103119.4801-1-colin.king@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Jan 22, 2018 at 11:31:19AM CET, colin.king@canonical.com wrote: >From: Colin Ian King > >Currently, if the call to devlink_resource_find returns null then >the error exit path does not free the devlink_resource 'resource' >and a memory leak occurs. Fix this by kfree'ing resource on the >error exit path. > >Detected by CoverityScan, CID#1464184 ("Resource leak") > >Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction") >Signed-off-by: Colin Ian King Acked-by: Jiri Pirko Thanks.