From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751251AbeAVQK3 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Jan 2018 11:10:29 -0500
Received: from verein.lst.de ([213.95.11.211]:53219 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751085AbeAVQK2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Jan 2018 11:10:28 -0500
Date: Mon, 22 Jan 2018 17:10:27 +0100
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
        Keith Busch <keith.busch@intel.com>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v4 1/2] nvme: add tracepoint for nvme_setup_cmd
Message-ID: <20180122161027.GA7097@lst.de>
References: <20180119141819.11938-1-jthumshirn@suse.de> <20180119141819.11938-2-jthumshirn@suse.de> <20180122152301.GA5818@lst.de> <20180122155356.4doy32sfgzwegmq4@linux-x5ow.site> <20180122155956.GA6635@lst.de> <20180122160437.4kct2cz2ihwymvct@linux-x5ow.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180122160437.4kct2cz2ihwymvct@linux-x5ow.site>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 22, 2018 at 05:04:37PM +0100, Johannes Thumshirn wrote:
> You mean like:
> 	if (ns)
> 		trace_nvme_setup_cmd(cmd);
> 	else
> 		trace_nvme_setup_admin_cmd(cmd);
> 
> ?

Yes.  Although I'd rename trace_nvme_setup_cmd to trace_nvme_setup_nvm_cmd
to prepare for new I/O command sets.