From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751356AbeAVTB4 (ORCPT ); Mon, 22 Jan 2018 14:01:56 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35164 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751170AbeAVTBz (ORCPT ); Mon, 22 Jan 2018 14:01:55 -0500 From: Ivan Mikhaylov To: Christian Lamparter Cc: "David S . Miller" , Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write Date: Mon, 22 Jan 2018 22:01:46 +0300 X-Mailer: git-send-email 2.10.1 (Apple Git-78) In-Reply-To: <2818110.k5nooOEKBD@debian64> References: <2818110.k5nooOEKBD@debian64> X-MIMETrack: Itemize by SMTP Server on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 22/01/2018 19:01:49, Serialize by Router on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 22/01/2018 19:01:49, Serialize complete at 22/01/2018 19:01:49 X-TNEFEvaluated: 1 X-TM-AS-GCONF: 00 x-cbid: 18012219-0020-0000-0000-000003ED7F4B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18012219-0021-0000-0000-0000427FC814 Message-Id: <20180122190146.22876-1-ivan@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-22_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801220262 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >Something looks wrong here?! The commit message talks about bit 18, 19 and 20. >However, 0x0800, 0x1000, 0x2000 and are like bit 11, 12 and 13? Furthermore, >what about the EMAC_STACR_STAC_MASK? shouldn't it be 0x1800 now (or delete it >since it doesn't look like it's used anywhere?). Christian, nope, it's all fine there, it's big endian. This commit related only to write operation, I'll check MASK and see what I can do with that.