From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751167AbeAVVvL (ORCPT ); Mon, 22 Jan 2018 16:51:11 -0500 Received: from mga14.intel.com ([192.55.52.115]:44900 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbeAVVvK (ORCPT ); Mon, 22 Jan 2018 16:51:10 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,398,1511856000"; d="scan'208";a="21721089" Date: Mon, 22 Jan 2018 14:54:36 -0700 From: Keith Busch To: Christoph Hellwig Cc: Jianchao Wang , axboe@fb.com, sagi@grimberg.me, maxg@mellanox.com, james.smart@broadcom.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure Message-ID: <20180122215436.GS12043@localhost.localdomain> References: <1516607585-1525-1-git-send-email-jianchao.w.wang@oracle.com> <20180122201423.GA30427@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180122201423.GA30427@lst.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 22, 2018 at 09:14:23PM +0100, Christoph Hellwig wrote: > > Link: https://lkml.org/lkml/2018/1/19/68 > > Suggested-by: Keith Busch > > Signed-off-by: Keith Busch > > Signed-off-by: Jianchao Wang > > Why does this have a signoff from Keith? Right, I hadn't signed off that. I just trying to get feeback if someting like that was closing the theoretical gap, which it does. I actually have something similar in my patch queue I was about to send around this area, though. I don't like having the IO path take on the error handling, and I think ending unstarted requests directly will be better long term.