From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2254F5QlQLjKJBKBdZsOhqmv4LQrj/qBxkTeVHXWoR0j5bBK4Vr0viLiB/tU8OP1AedqeW5L ARC-Seal: i=1; a=rsa-sha256; t=1516679487; cv=none; d=google.com; s=arc-20160816; b=A4uK8hi4eU2dNRYA80Ng/+eprU94q08uBXAJI1JV9sHTRbKe6JGx+fGrGr337KFezi +T0oKSJF9tEnoGRWTo97cnkw0et3KnjtjkXX4koD0CFm1tOFiwfIh9caeEtc9GmdBM0d VD1e4WIYQ3nDTPucG/e568QXG5PO1ERINAIGadlXngeBjVcMpyEtvGyF2Dk9pKhd+sFL QwMxTm65Fh7sKP2xZd5pe21rmgJ3tnBqlJvfjToLW6LRWEQjYFp/pYZUGgl+aF7a/7lM EU7UoDmEV1+GW5hgmL/ZlXe6HVE2OhY0I6rRkgA2mkt52uKVQEQm2lzYKENHGOTNgEUv ZFjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=GTybv4tsq+W9KrylClV2/C+wBKXnlEuncU40YzIl4ys=; b=repFGe4d35ZkdglpB0sAeqftJP4KHRdncQRRkeF0h7QOGtjpNOPSMCDN5/g30/p0DY pxbYULpZDBNV+uq7FnxLELOHtdBXjdUoX3joC7qLTjtGowzXVYyXqagNhY8YbPV6KJ8S 8SgGkfXIG70j5e15zyppzC1KZt3q6EvpKKYNI4cOnLfMQtT3Z29Kdi1AaYcQ7VZP5WQ0 4flpzzbVLYFs1+EyU35N2xk1AVjfZBVQaEtgGe62bSepeX88N3k+gGb/f42tLXYCyqgT Attn218Lmnf61yhptI7I/kA52dy2qq/NjuhNpKB2J8vmzsKNOWtrJGQmUg7+0oFA6wPG JONw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=WsHTP0ua; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=WsHTP0ua; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Mon, 22 Jan 2018 19:51:24 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Message-ID: <20180123035124.GB24956@fury> References: <1516213316-32278-1-git-send-email-vadimp@mellanox.com> <1516213316-32278-5-git-send-email-vadimp@mellanox.com> <20180123034946.GA24956@fury> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123034946.GA24956@fury> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589857579150135041?= X-GMAIL-MSGID: =?utf-8?q?1590353710139776214?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 22, 2018 at 07:49:46PM -0800, Darren Hart wrote: > On Wed, Jan 17, 2018 at 06:21:56PM +0000, Vadim Pasternak wrote: > > +#define MLXREG_CORE_LABEL_MAX_SIZE 32 > > + > > /** > > * struct mlxreg_hotplug_device - I2C device data: > > + * > > * @adapter: I2C device adapter; > > * @client: I2C device client; > > * @brdinfo: device board information; > > * @nr: I2C device adapter number, to which device is to be attached; > > - * @np - pointer to node platform associated with attribute; > > We just added this in 3/4. This should have just been skipped and done as it is > here directly, and only enabling ARM support at the end. Apologies, I was still working on this email when I accidentally sent it instead of postponing it. The above is true, but I'm working on fixing it in my branch. No need to resend at this point. -- Darren Hart VMware Open Source Technology Center