From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227HoVLTmJDa4XgxxtGfP1e1wNmZ9n0WE0F/O0rOPy3qjnKbxr7IzR1Wu7tqAfewR4FqgXrY ARC-Seal: i=1; a=rsa-sha256; t=1516679509; cv=none; d=google.com; s=arc-20160816; b=e0Sow3hsVgu19NIO9jUYW/A9sGt/GR//u+vFwn20hiwRVaHKYWnX2fhiuzKatc8PUr /+dWC5HV9bcrNTkkCX4fK4GLkOJnsyZvnEOvpulZV50FySVv9dtDmI5zojKv1AKcd3c7 8Ao3Sv9xiGjLaxSQEJq+uUjhTPA//NNfP2v/sCmPPzSITMsWn9dZ7NMu8f5WQ13KK4Hq gCfkez2PsFThK4EMw3uUDD+OVSH/8oqjoD5x1ZC3J1h+4BV2sGJuGG15YwKJBygUwGXw De3wcrnQFVsIrZvKU//7ofnzL+JUWwvOcgftw3xh7kymT0dNGDVh8gmJAtxbsytpn4d+ EzQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=ljMai3NDTgvWwrjiIGg1+aS92YcTAwudIFzx42FpFh4=; b=sLP22gw4pxQtm3wgrAK+NP7gJH9eCaGzEPuxeDyVECsxS7noK7zzhJNcJooHNA/9C0 i6FwOnMEEQzGLfgl82m8XL9EnT2+euLPz5dnwkN0kmQ6HJpUzgzKUPVBF4oeIHIxWv5a iWcrXyggzm6Eu74uMG1XCrXy5Uz5n6rD4CG3f8+qZi1JfwjtzVbfts/MgYFj77gXJ0KF ft2xgJB8os6e+ysW5KevpqH/3Sz4RHYEBWwU2ZshPj5QzevRQJQfjKDqCDexE79udzDE Er7/jx3+vTeiw8iVp0YDHSdqsEarOoZIFlJxZ+FOJO6d1zQ56isgxpppvdI1BwN7vMyP TUbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=kSHXFPEo; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=kSHXFPEo; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Mon, 22 Jan 2018 19:51:46 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v9 1/4] platform/x86: Move Mellanox hardware platform hotplug driver to platform/mellanox Message-ID: <20180123035146.GC24956@fury> References: <1516213316-32278-1-git-send-email-vadimp@mellanox.com> <1516213316-32278-2-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516213316-32278-2-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589857575885334071?= X-GMAIL-MSGID: =?utf-8?q?1590353733016993815?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 17, 2018 at 06:21:53PM +0000, Vadim Pasternak wrote: > It moves drivers/platform/x86/mlxcpld-hotplug.c to > drivers/platform/mellanox/mlxreg-hotplug.c and > include/linux/platform_data/mlxcpld-hotplug.h to > include/linux/platform_data/mlxreg.h for making hotplug driver usable for > the different machine architectures. > > Signed-off-by: Vadim Pasternak > Acked-by: Andy Shevchenko > --- > v9->v8: > Comments pointed out by Darren: > - make removing of X86_64 dependency of mlx-platform to a separate patch > since it is not related to the moving hotplug driver to > platform/mellanox; > v7->v8: > v6->v7: > Fixes added by Vadim: > - remove dependency on X86_64 to allow also X86 architecture; > v5->v6: > Fixes added by Vadim: > - add SPD license record to Kconfig and Makefile; > v4->v5: > Comments pointed out by Andy: > - arrange MAINTAINERS in correct alphabetic order; > v3->v4: > Comments pointed out by Darren: > - Refactor the patches to provide the changes in patchset in incremental > order; > - Modify MAINTAINERS records; > - Use git-mv for the replaced files; > Commnets pointed out by Colin: > - Make structures mlxplat_dev and mlxplat_hotplug static; > --- > MAINTAINERS | 7 +- > drivers/platform/Kconfig | 2 + > drivers/platform/Makefile | 1 + > drivers/platform/mellanox/Kconfig | 25 +++ > drivers/platform/mellanox/Makefile | 6 + > .../mlxreg-hotplug.c} | 223 ++++++++++----------- > drivers/platform/x86/Kconfig | 8 - > drivers/platform/x86/Makefile | 1 - > drivers/platform/x86/mlx-platform.c | 18 +- > .../platform_data/{mlxcpld-hotplug.h => mlxreg.h} | 25 ++- > 10 files changed, 170 insertions(+), 146 deletions(-) > create mode 100644 drivers/platform/mellanox/Kconfig > create mode 100644 drivers/platform/mellanox/Makefile > rename drivers/platform/{x86/mlxcpld-hotplug.c => mellanox/mlxreg-hotplug.c} (65%) > rename include/linux/platform_data/{mlxcpld-hotplug.h => mlxreg.h} (84%) > ... > diff --git a/drivers/platform/x86/mlxcpld-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c > similarity index 65% > rename from drivers/platform/x86/mlxcpld-hotplug.c > rename to drivers/platform/mellanox/mlxreg-hotplug.c > index aff3686..2866c76 100644 > --- a/drivers/platform/x86/mlxcpld-hotplug.c > +++ b/drivers/platform/mellanox/mlxreg-hotplug.c > @@ -1,7 +1,6 @@ > /* > - * drivers/platform/x86/mlxcpld-hotplug.c > - * Copyright (c) 2016 Mellanox Technologies. All rights reserved. > - * Copyright (c) 2016 Vadim Pasternak > + * Copyright (c) 2017 Mellanox Technologies. All rights reserved. > + * Copyright (c) 2017 Vadim Pasternak Copyright should persist across git rename. I've updated this to 2016-2018 on both lines. > /* Offset of event and mask registers from status register */ > -#define MLXCPLD_HOTPLUG_EVENT_OFF 1 > -#define MLXCPLD_HOTPLUG_MASK_OFF 2 > -#define MLXCPLD_HOTPLUG_AGGR_MASK_OFF 1 > +#define MLXREG_HOTPLUG_EVENT_OFF 1 > +#define MLXREG_HOTPLUG_MASK_OFF 2 > +#define MLXREG_HOTPLUG_AGGR_MASK_OFF 1 This, and much of what follows, is an additional change from the move, but it is not called out in the changelog. I've added a note to the changelog about renaming from MLXCPLD to MLXREG. No need to resend. -- Darren Hart VMware Open Source Technology Center