From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup
Date: Mon, 22 Jan 2018 19:53:57 -0800 [thread overview]
Message-ID: <20180123035357.GD24956@fury> (raw)
In-Reply-To: <1516213316-32278-4-git-send-email-vadimp@mellanox.com>
On Wed, Jan 17, 2018 at 06:21:55PM +0000, Vadim Pasternak wrote:
As I continue to pick these patches apart into their individual functional
changes, I'm finding more issues...
> Renaming field bus in structure mlxreg_hotplug_device to nr to have a name
> consistent with Linux i2c naming.
>
> Removing unnecessary includes.
>
> Removing from mlxreg_hotplug_device_create dev_err to upper layer should
> produce error on EFAULT return.
>
But the only caller doesn't check the return code. Where did you expect for this
error to be detected?
> Relocation mlxreg_hotplug_device_create/destroy to the beginning of the
> mlxreg-hotplug.c in order to have attribute related code at the same
> location.
>
> Add to structure mlxreg_hotplug_device device node handle for devices
> defined in device table tree;
>
The above should *really* be several changes. Start with the non-functional
preparatory changes, followed by single functional change. Also, it seems to me
adding the device node prior to enabling building on ARM would make sense??
I've broken this up, verified incremental build, and rewritten the commit
messages. I have this sitting in a local branch currently.
I need you to respond to the question above re the create call, but I'll make
the change myself.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-01-23 3:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:21 [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak
2018-01-17 18:21 ` [patch v9 1/4] platform/x86: Move Mellanox hardware platform hotplug driver to platform/mellanox Vadim Pasternak
2018-01-23 3:51 ` Darren Hart
2018-01-17 18:21 ` [patch v9 2/4] platform/mellanox: mlxreg-hotplug: Allow driver for ARM architecture Vadim Pasternak
2018-01-17 18:21 ` [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup Vadim Pasternak
2018-01-23 3:53 ` Darren Hart [this message]
2018-01-23 4:03 ` Darren Hart
2018-01-17 18:21 ` [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Vadim Pasternak
2018-01-23 3:49 ` Darren Hart
2018-01-23 3:51 ` Darren Hart
2018-01-23 4:13 ` [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Darren Hart
2018-01-23 18:04 ` Vadim Pasternak
2018-01-23 21:54 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123035357.GD24956@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox