From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227CCsDSPFR2RFrj0gFgnAe5xawr/vka1g4wFgGqQpUStRTn+r2A0EpAvq8UiFuiQabEx5ca ARC-Seal: i=1; a=rsa-sha256; t=1516679639; cv=none; d=google.com; s=arc-20160816; b=ZhtIwbeB1/2FlozgoSV8f1H+Y/nMqDhpGFSV19BT+vadRE6j6xhnZT/4NKNqDzxRor S1l8HwuyHOy4vqUxa+SGabUD0Ozt0yblQ3wCOF/0S0GrAPfZzxsIjgvv1LhY5Uf1LNbR mDKisgedAXdfXZf7W9O/YLcVT8tuDWntEu4es/moS4siPoabHmBrSsuSNL7LduDNURSk g8LMspAHIc+OEB3nFZth9pXndCmN2L0lTA6Xml/c+ZdZU9ewfyMBucUpm7ce9D/Jv4zR o8NCLADcIaOsr6VDorEWgCQlqXdFBjb16JnOXJHDzEVbhDl/DKaES9Y/ucNUZ+b5uSGY tXCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=vmUn8dcuRIOvRb1PK6WMSvD1M+NhjKQbG7S5/tOg4U8=; b=Fp2Y7HdP0AN6O4+ZDXDX2NY3QuLpXls2qOCKKFLQGZSk4TTwaWlwTy4G4T9KkFbLFx ROguomc3czm9IgKOsfpgCxltU0XIOBB0fVZi2JRKOIVkOG2tOFUJNXKwApLW3ZOrkcwo a5+CE/cq2IWtnHbjAF+26tUL9MUTUh5s6tujzI80GKc+ZMOPojcX+6C5NSypnh0dzu58 mrDAK+7koNIhGALSoLWcA//fvJhIccfW4sbQ6lULnOXAmuSgLySL6hE8hdA7Ro6ZDo30 G7DDzbIqp+LgIkaE7d+3uNu+FXGuAzYjZhEIg+onQUoiprchMLETHawgPiQYUVrP2whU d5wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=cnMbWU1i; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=cnMbWU1i; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Mon, 22 Jan 2018 19:53:57 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup Message-ID: <20180123035357.GD24956@fury> References: <1516213316-32278-1-git-send-email-vadimp@mellanox.com> <1516213316-32278-4-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516213316-32278-4-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589857576208832039?= X-GMAIL-MSGID: =?utf-8?q?1590353869798898200?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 17, 2018 at 06:21:55PM +0000, Vadim Pasternak wrote: As I continue to pick these patches apart into their individual functional changes, I'm finding more issues... > Renaming field bus in structure mlxreg_hotplug_device to nr to have a name > consistent with Linux i2c naming. > > Removing unnecessary includes. > > Removing from mlxreg_hotplug_device_create dev_err to upper layer should > produce error on EFAULT return. > But the only caller doesn't check the return code. Where did you expect for this error to be detected? > Relocation mlxreg_hotplug_device_create/destroy to the beginning of the > mlxreg-hotplug.c in order to have attribute related code at the same > location. > > Add to structure mlxreg_hotplug_device device node handle for devices > defined in device table tree; > The above should *really* be several changes. Start with the non-functional preparatory changes, followed by single functional change. Also, it seems to me adding the device node prior to enabling building on ARM would make sense?? I've broken this up, verified incremental build, and rewritten the commit messages. I have this sitting in a local branch currently. I need you to respond to the question above re the create call, but I'll make the change myself. -- Darren Hart VMware Open Source Technology Center