From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup
Date: Mon, 22 Jan 2018 20:03:10 -0800 [thread overview]
Message-ID: <20180123040310.GE24956@fury> (raw)
In-Reply-To: <1516213316-32278-4-git-send-email-vadimp@mellanox.com>
On Wed, Jan 17, 2018 at 06:21:55PM +0000, Vadim Pasternak wrote:
> Removing unnecessary includes.
...
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
> index 2866c76..556e612 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -41,8 +41,6 @@
> #include <linux/module.h>
> #include <linux/platform_data/mlxreg.h>
> #include <linux/platform_device.h>
> -#include <linux/spinlock.h>
But spinlock IS required. Just because some other include eventually also
includes it doesn't meet we can drop it here. We use functions defined in
spinlock.h, so it needs to be included.
I've updated this in my branch...
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-01-23 4:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:21 [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak
2018-01-17 18:21 ` [patch v9 1/4] platform/x86: Move Mellanox hardware platform hotplug driver to platform/mellanox Vadim Pasternak
2018-01-23 3:51 ` Darren Hart
2018-01-17 18:21 ` [patch v9 2/4] platform/mellanox: mlxreg-hotplug: Allow driver for ARM architecture Vadim Pasternak
2018-01-17 18:21 ` [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup Vadim Pasternak
2018-01-23 3:53 ` Darren Hart
2018-01-23 4:03 ` Darren Hart [this message]
2018-01-17 18:21 ` [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Vadim Pasternak
2018-01-23 3:49 ` Darren Hart
2018-01-23 3:51 ` Darren Hart
2018-01-23 4:13 ` [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Darren Hart
2018-01-23 18:04 ` Vadim Pasternak
2018-01-23 21:54 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123040310.GE24956@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox