From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dvhart@infradead.org>
X-Google-Smtp-Source: AH8x224XHzZRguBeE+3hTHTwOt7xLABub1IuFEi6UwMNSx4NUlnWiQdbLSrG1DwUIsbKzdGzHPDI
ARC-Seal: i=1; a=rsa-sha256; t=1516680194; cv=none;
        d=google.com; s=arc-20160816;
        b=nSo0tItTgNUtza2Izl11rGAZTSpPK7rGoaDLXJQV5KFHa0PewiqDq6sAUQlskvl2nP
         CpdNiRxd7dWPWxDesDTjidrzlShYvA0jLRZ1MTyClLkVAO5ORVq648tBsqcjAU2kyDDx
         SrQABIpeiMHiFDLushmo+RcHc+Cp7mWAPCaGDb81kKN+Dj9m57Fmr9O8Qr1zJzm8fj5H
         UuO5YkuFDC4q4CuuW0WAi/fR7QxYmmL1o8B2O9lovT3cBCTPEu4IxbTz6vuywUG4PIce
         WbUKO0EIMw6wW46x1LOV19HaYt+XXoDnj3JGh2kXJKHcHShX5nbvog3LPJTxpLqjWU9D
         nLgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:dkim-signature
         :arc-authentication-results;
        bh=xWxfXrLecrUjPLO9UGFgt80tvFYIdWfC5WfDA1ioXyI=;
        b=ESmxYWonYvHelaD2ihmLR537+GvtbZCwm60X5ycI8xDihcb4nzgbuVRbxEyg6gmoDG
         o1bu31YcWc5b33eGB+DX8qUxTJ3FQocL69lD5+7zvO1CvjFC6muGt+mNPA6TPvX31f6Y
         gWVYdCi3pc/niXfpMY9gyjMO9T1M6VXdEuMzVCX9mG66VkSPUxFjIf7cHzJQ546+xTsv
         bjFGH6LsqLbjPmO7g8Sq7bJbnQqH6ha43PWxnrzNHdVnmJmnUNt3l+BCkm5GUdlllxtL
         LmJG09a7tZg9hDl2cNpgTJ9S3O0TvH0FlGBRavHGjRK0QfbP+q8diM2A40V5fAAek5l3
         SgUg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=TWlq/tJF;
       spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=TWlq/tJF;
       spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org
Date: Mon, 22 Jan 2018 20:03:10 -0800
From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	jiri@resnulli.us
Subject: Re: [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup
Message-ID: <20180123040310.GE24956@fury>
References: <1516213316-32278-1-git-send-email-vadimp@mellanox.com>
 <1516213316-32278-4-git-send-email-vadimp@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1516213316-32278-4-git-send-email-vadimp@mellanox.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589857576208832039?=
X-GMAIL-MSGID: =?utf-8?q?1590354451454655573?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Wed, Jan 17, 2018 at 06:21:55PM +0000, Vadim Pasternak wrote:
> Removing unnecessary includes.
...
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
> index 2866c76..556e612 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -41,8 +41,6 @@
>  #include <linux/module.h>
>  #include <linux/platform_data/mlxreg.h>
>  #include <linux/platform_device.h>
> -#include <linux/spinlock.h>

But spinlock IS required. Just because some other include eventually also
includes it doesn't meet we can drop it here. We use functions defined in
spinlock.h, so it needs to be included.

I've updated this in my branch...

-- 
Darren Hart
VMware Open Source Technology Center