From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug
Date: Mon, 22 Jan 2018 20:13:28 -0800 [thread overview]
Message-ID: <20180123041328.GF24956@fury> (raw)
In-Reply-To: <1516213316-32278-1-git-send-email-vadimp@mellanox.com>
On Wed, Jan 17, 2018 at 06:21:52PM +0000, Vadim Pasternak wrote:
> The patchset:
> - replaces modules include/linux/platform_data/mlxcpld-hotplug.h and
> drivers/platform/x86/mlxcpld-hotplug.c with the modules
> include/linux/platform_data/mlxreg.h and
> drivers/platform/mellanox/mlxreg-hotplug.c;
> relevant Makefile and Kconfig are updated;
> - modifies Mellanox hotplug driver for making it architecture
> independent. Drivers has been tested for x86 and ARM based systems.
> - includes code cleanup;
> - introduces regmap interface for mlxreg-hotplug driver to allow hotplug
> event functionality over programmable devices logic, when these devices
> can be attached to different interfaces types, like I2C, LPC, SPI;
> driver drivers/platform/x86/mlx-platform.c is updated according to new
> interface.
This series is still not dividing up changes into small functional chunks. It
"ping pongs" (adding then later removing code), and makes it difficult to review
functional changes by surrounding them with non-functional transformations. As
I've attempted to break this apart myself, I've discovered a few issues with the
code - see the responses to the individual patches.
You can find my broken up version here:
http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/review-dvhart-mellanox-v10
In particular, please see:
http://git.infradead.org/linux-platform-drivers-x86.git/commit/4f0057fc3da29c04e2cefca9dc5b17577b3e4988
Vadim, please respond to my questions re the individual patches, and I'll
increment the patches in the above branch before pushing this up to testing.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-01-23 4:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:21 [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak
2018-01-17 18:21 ` [patch v9 1/4] platform/x86: Move Mellanox hardware platform hotplug driver to platform/mellanox Vadim Pasternak
2018-01-23 3:51 ` Darren Hart
2018-01-17 18:21 ` [patch v9 2/4] platform/mellanox: mlxreg-hotplug: Allow driver for ARM architecture Vadim Pasternak
2018-01-17 18:21 ` [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup Vadim Pasternak
2018-01-23 3:53 ` Darren Hart
2018-01-23 4:03 ` Darren Hart
2018-01-17 18:21 ` [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Vadim Pasternak
2018-01-23 3:49 ` Darren Hart
2018-01-23 3:51 ` Darren Hart
2018-01-23 4:13 ` Darren Hart [this message]
2018-01-23 18:04 ` [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak
2018-01-23 21:54 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123041328.GF24956@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox