From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225MSHlODL2CE0lc7L9V6CqJQu2iQnzAR3dqDzkJNxpYq7ws94iGuCXy0al0aysgz0Vkmxnj ARC-Seal: i=1; a=rsa-sha256; t=1516680811; cv=none; d=google.com; s=arc-20160816; b=dVOJJbvhxGmdGnWDjc54KX7JKBi1mq8eb6wBPV4gAT1YbAemmsg/Tjz/bclZbeaoMa Vk6zT1xbcRyHij8W2kA11YPZebf9mgP2kH8Du/n/Hr172XYLxMe5Pu9EebNF7yFYmPAc xv1qCMaS4ldE4O+8ofWgFxb79bylXhWcbnbEdd4fi1C7JQi+dk98FfMHU9iDr2Oh5B2s F84wwOSmUQidMHTRzQ1CT+p0PTcjneRRXkzdYSlWXRQzQNpwO5GBbA2r6tRM1F6W63Xx I9APH6xgwma3PVLOf+D5TyJt4tMiG1APP+qPbmuxTTnD+b7gWHNtX15s//2gmrAk3D2k o7cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=+2puZBIhdMNIExlsw07LOtRdfrvka3XDlSJ2jduzdNU=; b=LPmZUQUCpoKpx7RxieWSSligtnTPzWARqEjNaw47E6wXOmpNxpKfPNGOUufVpEdPm1 Ocur7POA2h1iazc+/JhdjTvP5abg6pqp5ARlFFa6TrPawO0bJgoNCDsabXnT6oc0TLp8 O3vsRXuQTOkTjYHnTecT8XhGC8fmqa6G2C0tHJnSiarKkYEJXDOJxi3LimTXsGWkC5tG 5l52ojX2ncQOwIE5+gH2+J1BOV9WEU5xhEB/HseJfBW53RIHQyL3HQDIFLSE1sdx3EUA C+eqZY4GEn8zGnJvkhZnYuf+q3sKPpHC7iEVcemAYBrufe1Cg8qPOHd15gExIQUJ6uut KNJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=XWYmI7DS; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=XWYmI7DS; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Mon, 22 Jan 2018 20:13:28 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Message-ID: <20180123041328.GF24956@fury> References: <1516213316-32278-1-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516213316-32278-1-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589857572197066942?= X-GMAIL-MSGID: =?utf-8?q?1590355098998377898?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 17, 2018 at 06:21:52PM +0000, Vadim Pasternak wrote: > The patchset: > - replaces modules include/linux/platform_data/mlxcpld-hotplug.h and > drivers/platform/x86/mlxcpld-hotplug.c with the modules > include/linux/platform_data/mlxreg.h and > drivers/platform/mellanox/mlxreg-hotplug.c; > relevant Makefile and Kconfig are updated; > - modifies Mellanox hotplug driver for making it architecture > independent. Drivers has been tested for x86 and ARM based systems. > - includes code cleanup; > - introduces regmap interface for mlxreg-hotplug driver to allow hotplug > event functionality over programmable devices logic, when these devices > can be attached to different interfaces types, like I2C, LPC, SPI; > driver drivers/platform/x86/mlx-platform.c is updated according to new > interface. This series is still not dividing up changes into small functional chunks. It "ping pongs" (adding then later removing code), and makes it difficult to review functional changes by surrounding them with non-functional transformations. As I've attempted to break this apart myself, I've discovered a few issues with the code - see the responses to the individual patches. You can find my broken up version here: http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/review-dvhart-mellanox-v10 In particular, please see: http://git.infradead.org/linux-platform-drivers-x86.git/commit/4f0057fc3da29c04e2cefca9dc5b17577b3e4988 Vadim, please respond to my questions re the individual patches, and I'll increment the patches in the above branch before pushing this up to testing. -- Darren Hart VMware Open Source Technology Center