Re: [PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

Brian Norris
2018-01-25T22:51:04Z

On Thu, Jan 25, 2018 at 4:16 AM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> On 24.01.2018 19:37, Brian Norris wrote:
>> With your current patch, you're returning the 'mipi_dsi_packet::size',
>> which is the sum of both TX and RX.
>
> I did not found docs saying mipi_dsi_packet::size is a sum of tx and rx.
> tx and rx packets are two different packets, so they do not sum up.
> But thanks for bringing it up, it shows docs are incomplete/misleading.

Ugh, I misread that again. No, mipi_dsi_packet::size is NOT claimed to
contain both TX and RX. It just says "size of the packet", and packet
clearly does not hold the RX data anyway. I don't know what's
happening to my reading comprehension...

But the mismatch on whether drivers implement these correctly and
whether any callers actually care about the documented semantics still
stands.

Brian