From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224XxlKEAQtQ7kdSFJAoiuz1jzJYUuUPRpaXUX89c9c/OYyTWz1lIhFLVxiV7h69C1N1+5hQ ARC-Seal: i=1; a=rsa-sha256; t=1516767602; cv=none; d=google.com; s=arc-20160816; b=otBDbgyQIdJO6TdnLlb7fhXruadoKe/K9n86xihf9RcOxa2F58YmwBLuQdJ4gU/3aM rCncJTSJjUA4VDjl7LqnToMrEMKl+Q7Nj7WXXDBCf/n0BBS91pXXVHHvm/PM0OnIpJ0L vkiM/UYPEjAtFsmFkqOJbKRXQyhh/n8hmlHCqfTsS9PZF+Cne9nlmK2LQOqTpDf/IAuK BAXLmPDJ2YBQX79tyE3q3kYhMaVv0b+5AJRtBVX5yoJqnglHf27inIu3uUiJGIVbo9e+ 4iiZGlzi88hS+g0iQh0tQ+j3BgjJtR2PtW2AscmliMLvS75OOvyPTAzUkbOWFSdcihU5 ipFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=saMXe3NsxVd0DWqe8ZryeOPr1V9WXyJUmEp4BuIfmXY=; b=cdvyS5/7cKQxzQDcUIC2m0GIUaDVdDgwobE2vW32HtaTXS3TXWqwtSKnfs+3OUcret +DcHwK7tiHGlaMWnXsE4se1x8VnmTc7TbUtfpp9ZNSd1DV9IXQT1Q4AqU+N0yLZKow7G tQeapkVeC9OmucEfTTqXe5zc93X26vLz69qJIuv9tg+HWLmbJSenu13pnqeyLs0E+c6d g2e+KSabkNgenk+Qbha0XVutZpx5yKk+JLWPtZem1pFMYiBkAZ2f8Mq5LazHkaQDXsaC naTtSYN7qwndkPwpI8bgx3PYvORAq24aBK9Iye9WolGTyIvruHJ+CeVskVdjWSd59hCw ysDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WnRknRF+; spf=pass (google.com: domain of alexander.levin@microsoft.com designates 104.47.42.90 as permitted sender) smtp.mailfrom=Alexander.Levin@microsoft.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WnRknRF+; spf=pass (google.com: domain of alexander.levin@microsoft.com designates 104.47.42.90 as permitted sender) smtp.mailfrom=Alexander.Levin@microsoft.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Larry Finger , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 35/35] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Thread-Topic: [PATCH AUTOSEL for 4.4 35/35] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Thread-Index: AQHTlMo0S3KyPX8aaUu0RIZDvoMsqA== Date: Wed, 24 Jan 2018 04:17:10 +0000 Message-ID: <20180124041645.32420-35-alexander.levin@microsoft.com> References: <20180124041645.32420-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041645.32420-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0998;6:bpJUOlO9ruQol1P6uZrogDTvnN8guDZJ3JYsJDsPu4632T9TdtrVR3hzbQH5fKVUXbpt/W759kl/yyUTbXprEhfvj8ucAfLd1+wcR+H7aJ8q8ZmpsfOQC4Oxb4n0/7I5aNtzFNkTnmwfBU7G+e7MsDd2DmKPQGvubKRWM6reNgGejs5+icse1u/eg8M8bLcImPEI6DHmBz7Zbn2IgGwvrkJSJih8qEc5gsUieE5ljctjvHZMI/7DtrD3wyJ+i23mz9q5dRpeugDyP2uKU9Qxju2X/igIhR7HtuBhMtIucZDMU89jVl4KFHlM2jkt5U0HRXwQcneNB1T9mCIjegyQYygCYFyHZhNSEsFC2mmsM8yp0yqwpwAy0RZKQnOvOebb;5:YCKuXIkNFaYAG/dP3WCg3reM85aP+fg9v5Eh9dveBURPRlWSlab8f4Tv7fIbZ5+FyakKEOiCnmdv0LlXzgk95HxtD3VgGv2KIdHpr0NiAkJvRFrVH/1C0n71gUj5ZOQnEh8Ts02YPU3XNQeUONX+mWgls205x4JqSi10epPEwmk=;24:jLN3Gw58s2OAI/PxfkvFgPPvXFGr6W5MdDnFg/Gi2aMvo3dRWhTHzLlnzZro2ucwmd4Bdfx7r3Nm6+sy/JoKvKmG0GDSKrpgWbLJJQU3kxk=;7:KLbL9ezLWfKycUzBSAkWlF75VY2m1+7FLWefazSyaewZ2/OwL2b/6qDTBwA5qyakvaGUiR0wnQLVd+2R6LYne9ZnrzqrjZMIGxWPQxr/mfYRm3KByk8WML49qbuDBLLtrpZDXo/AeUtp+QCe3PpSQ02ImrVUqfZsK4M62ICXwb/W4yTAMza/VFwir+VXVLu+asdV6pocp25WVSDhCQv4NeTCqMWAjhGqWTgTF0FXnXulpFg6tt8Ph3e1WK73m4a0 x-ms-office365-filtering-correlation-id: fdfa074e-a4b0-49bd-6584-08d562e1bc19 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB0998; x-ms-traffictypediagnostic: DM5PR2101MB0998: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231046)(2400081)(944501161)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:DM5PR2101MB0998;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0998; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(39380400002)(346002)(39860400002)(396003)(376002)(199004)(189003)(14454004)(3660700001)(6346003)(10290500003)(105586002)(66066001)(6506007)(8676002)(22452003)(86612001)(54906003)(10090500001)(81166006)(81156014)(76176011)(110136005)(86362001)(68736007)(106356001)(8936002)(3280700002)(6306002)(36756003)(25786009)(107886003)(2501003)(6666003)(966005)(99286004)(2906002)(26005)(2950100002)(72206003)(102836004)(305945005)(6116002)(3846002)(5660300001)(4326008)(478600001)(316002)(53936002)(97736004)(2900100001)(5250100002)(6512007)(6436002)(6486002)(1076002)(7736002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0998;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: nvKvHjLrJG56srxlGmDJkSekIidQ2wLzYSiooFakSab7eSWER6Pp0LvOWvk/KidF17yyxyQ1GhT9NWpIHKG87w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdfa074e-a4b0-49bd-6584-08d562e1bc19 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:17:10.9612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0998 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590445897220931135?= X-GMAIL-MSGID: =?utf-8?q?1590446105580631263?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Larry Finger [ Upstream commit b77992d2df9e47144354d1b25328b180afa33442 ] When not associated with an AP, wifi device drivers should respond to the SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the behavior expected by dhcpcd. Currently, this driver returns an error code (-1) from the ioctl call, which causes dhcpcd to assume that the device is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8188eu/os_dep/ioctl_linux.c index a076ede50b22..ec90f2781085 100644 --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c @@ -1399,19 +1399,13 @@ static int rtw_wx_get_essid(struct net_device *dev, if ((check_fwstate(pmlmepriv, _FW_LINKED)) || (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { len =3D pcur_bss->Ssid.SsidLength; - - wrqu->essid.length =3D len; - memcpy(extra, pcur_bss->Ssid.Ssid, len); - - wrqu->essid.flags =3D 1; } else { - ret =3D -1; - goto exit; + len =3D 0; + *extra =3D 0; } - -exit: - + wrqu->essid.length =3D len; + wrqu->essid.flags =3D 1; =20 return ret; } --=20 2.11.0