From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Wed, 24 Jan 2018 05:26:31 +0100
From: Greg Kroah-Hartman <gregkh@linux-foundation.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>, Borislav Petkov <bp@alien8.de>,
	David Woodhouse <dwmw@amazon.co.uk>, Paul Turner <pjt@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Kees Cook <keescook@google.com>, Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@amacapital.net>, gnomes@lxorguk.ukuu.org.uk,
	x86@kernel.org, thomas.lendacky@amd.com,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v8 04/12] x86/spectre: Add boot time option to select
 Spectre v2 mitigation
Message-ID: <20180124042631.GA6920@kroah.com>
References: <1515707194-20531-1-git-send-email-dwmw@amazon.co.uk>
 <1515707194-20531-5-git-send-email-dwmw@amazon.co.uk>
 <20180123224014.dsbzps4hydt6h7ed@pd.tnic>
 <nycvar.YFH.7.76.1801232348060.11852@cbobk.fhfr.pm>
 <20180123232125.GS7844@tassilo.jf.intel.com>
 <nycvar.YFH.7.76.1801240022450.11852@cbobk.fhfr.pm>
 <20180123234529.GU7844@tassilo.jf.intel.com>
 <nycvar.YFH.7.76.1801240046580.11852@cbobk.fhfr.pm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <nycvar.YFH.7.76.1801240046580.11852@cbobk.fhfr.pm>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Wed, Jan 24, 2018 at 12:49:37AM +0100, Jiri Kosina wrote:
> On Tue, 23 Jan 2018, Andi Kleen wrote:
> 
> > > Thanks for pointing this out, Andi. I've been just now writing more or 
> > > less the same thing; ditching that and will reuse your patch instead.
> > > 
> > > Why was the more aggresive version (6cfb521ac0d5b) merged into Linus' tree 
> > > instead of that?
> > 
> > Greg prefered using modversions
> 
> Ah. OK, Greg: I'll eat my hat (I've heard that's very popular these times) 
> if there is a major enterprise distro that doesn't revert this patch 
> immediately.

But will Andi's patch work well for you?  Adding a MODULE_INFO() tag to
every module?  I just thought since you were already using modversions
in enterprise distros already, that adding it there would be the
simplest.

If I am wrong, great, let's revert this and add something that you
really will use, otherwise it's just pointless code :)

Perhaps adding a MODULE_INFO() tag for the entire gcc and ld flags would
be nice in the end, as others have pointed out in this thread, but I
don't know if that solves your issue here or not.

thanks,

greg k-h