From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932204AbeAXH2r (ORCPT ); Wed, 24 Jan 2018 02:28:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51258 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932084AbeAXH2p (ORCPT ); Wed, 24 Jan 2018 02:28:45 -0500 Date: Wed, 24 Jan 2018 08:28:42 +0100 From: Jiri Olsa To: Jin Yao Cc: mathieu.poirier@linaro.org, acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2] perf util: Use target->per_thread and target->system_wide flags Message-ID: <20180124072842.GA8473@krava> References: <1516785576-9815-1-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516785576-9815-1-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 24, 2018 at 05:19:36PM +0800, Jin Yao wrote: > Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map: > Enumerate all threads from /proc") that it has negative impact on > 'perf record --per-thread'. It has the effect of creating a kernel event > for each thread in the system for 'perf record --per-thread'. > > Mathieu Poirier's patch ("perf util: Do not reuse target->per_thread flag") > can fix this issue by creating a new target->all_threads flag. > > This patch is based on Mathieu Poirier's patch but it doesn't use a new > target->all_threads flag. This patch just uses 'target->per_thread && > target->system_wide' as a condition to check for all threads case. > > v2: > --- > According to Jiri's comment, add description to explain why the patch > uses 'target->per_thread && target->system_wide'. > > v2 doesn't have functional change. Acked-by: Jiri Olsa thanks, jirka