From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932146AbeAXHq4 (ORCPT ); Wed, 24 Jan 2018 02:46:56 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:43262 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbeAXHqx (ORCPT ); Wed, 24 Jan 2018 02:46:53 -0500 X-Google-Smtp-Source: AH8x225u6GHUrpor3/qnDlHPx6dXw11Jcp9glx6dmxbS+6jkdhvyaOqEtIdB06GRAsMfjFs1UtWkEg== Date: Wed, 24 Jan 2018 08:46:50 +0100 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Nikolay Borisov , Josh Poimboeuf , Linus Torvalds Subject: Re: [PATCH 0/3] ftrace, orc, x86, tracing: Fix stack traces again Message-ID: <20180124074649.tuf4imeeerxb6cyb@gmail.com> References: <20180123183216.191160315@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123183216.191160315@goodmis.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > > With the new ORC unwinder, ftrace stack tracing became disfunctional. > > One was that ORC didn't know how to handle the ftrace callbacks in > general (which Josh fixed). The other was that ORC would just bail > if it hit a dynamically allocated trampoline. I added a check to > the ORC unwinder to see if the trampoline belonged to ftrace, and > if it did, use the orc entry of the static trampoline that was used > to create the dynamic one (it would be identical). > > Finally, I noticed that the skip values of the stack tracing is out > of whack. I went through and fixed them. > > Anyone have any issues with these patches? I'm starting my tests on > them now and if all goes well, I plan on pushing them to Linus > hopefully tonight. No fundamental objections from me, assuming they are well tested. Thanks, Ingo