From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1935064-1516811840-2-4103932355194838742 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.137', Host='smtp4.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516811839; b=L5Cuj8aeJC7y5PYlKGBYVqeSl1eDv4atfFm/sOJ/QuR1U1y l6eOBDjHUIcx9VhQlyrRcGgsWjN0nmwdwyPxKT8L8h4fdXNhlZ5a6hcFcFLLxOpg Jb1q+IDcEceJqUuFgVoIhPjIgHHe8mIBBy/RF+wr/J7MGzTJxaAEdvAEaIQ4yWKR x1S7XvxdL9d7d9UQF76GOHZXB+BtPNNdNoskzAuCJNETI2BJeO1EtvNzCMuCuSDz ZC/ySI76cHCJ+0XEcMiw7Jq9Y+0cvHdZU4ww3WOCeLLcm3jCfmspEagO6ruHsn4A +WA/9Uy4OtYszON2K8CAYhR5UfPZNv8se+J6Izw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :in-reply-to:references:mime-version:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516811839; bh=1 za620eURLIB62nqeNDsvRQVF0aUjgsCy+mEKyJmG0Q=; b=tY+L76HQdG3IH1JM2 v80Vm/2JfdxdFUMSjVg7+zDppSP2Sk99jqx3pg4mHwyoCsfwLKSGYq7jrYSyFj/o 2uxI7TrLE1+y9QY+KL3XXFwluycJD2IM6YCPhlJTzxoeRA1ajI3GafdUrsJKr4uK 3vLxs+nXI+hEx/FZGqmDcl7L7JM6wFHDFoiC/uUBMqfjmlP5VSWQA2XirTACR2Sk dKHvUrGGNyty4wFAOyYCnbPwbbjLpghbzHqRLBeX9DPYVvDfCvdXmfDo9a9jOpH/ 00PqFt4tQFKGYXdb3KihWVTsnXdOOqiME9wzdWWzxKosUi0s+ez123vA8qTzJmMY vyxuA== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b=Z5Nizxpg x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20150623; dmarc=none (p=none,has-list-id=yes,d=none) header.from=networkplumber.org; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=d9z9ClEi; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=networkplumber.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b=Z5Nizxpg x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20150623; dmarc=none (p=none,has-list-id=yes,d=none) header.from=networkplumber.org; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=d9z9ClEi; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=networkplumber.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Google-Smtp-Source: AH8x227odXpGMPgaOQWyofOEVuU35nhRsyqmogr06JIAFqxGLehuVx4jQtX0Du6vHPNV6Z72w3N23A== Date: Wed, 24 Jan 2018 08:37:07 -0800 From: Stephen Hemminger To: lantianyu1986@gmail.com Subject: Re: [Patch] vmbus: Simply hv_get_next_write_location() function Message-ID: <20180124083707.411368b7@xeon-e3> In-Reply-To: <1516774890-5134-1-git-send-email-Tianyu.Lan@microsoft.com> References: <1516774890-5134-1-git-send-email-Tianyu.Lan@microsoft.com> MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tianyu Lan , devel@linuxdriverproject.org, haiyangz@microsoft.com, sthemmin@microsoft.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, 24 Jan 2018 14:21:30 +0800 lantianyu1986@gmail.com wrote: > From: Tianyu Lan > > The "next" variable is redundant in hv_get_next_write_location(). > This patch is to remove it and return write_index directly. > > Signed-off-by: Tianyu Lan > --- > drivers/hv/ring_buffer.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c > index 12eb8ca..71558e7 100644 > --- a/drivers/hv/ring_buffer.c > +++ b/drivers/hv/ring_buffer.c > @@ -82,9 +82,7 @@ static void hv_signal_on_write(u32 old_write, struct vmbus_channel *channel) > static inline u32 > hv_get_next_write_location(struct hv_ring_buffer_info *ring_info) > { > - u32 next = ring_info->ring_buffer->write_index; > - > - return next; > + return ring_info->ring_buffer->write_index; > } > > /* Set the next write location for the specified ring buffer. */ Looks good. But let's go farther since function is only used in one location in the file just eliminate it completely and do simple variable references. The get/set functions in this file are unnecessary. Better still it is possible to replace the lock based ring structure with a compare-exchange solution. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel