From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933055AbeAXJ5V (ORCPT ); Wed, 24 Jan 2018 04:57:21 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37624 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932696AbeAXJ5T (ORCPT ); Wed, 24 Jan 2018 04:57:19 -0500 X-Google-Smtp-Source: AH8x227eiQazImuW00u2Q7dLk60i4C+4bz8pF1Y4qx5wjdbYs2ai0rn4Wii+z3grScYo7+ThjvlMJw== Date: Wed, 24 Jan 2018 15:27:14 +0530 From: gaurav jindal To: peterz@infradead.org, mingo@redhat.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH]sched: completion: use bool in try_wait_for_completion Message-ID: <20180124095714.GB20693@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use bool in place of int in the function try_wait_for_completion. Signed-off-by: Gaurav Jindal --- diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c index 0926aef..3e15e8d 100644 --- a/kernel/sched/completion.c +++ b/kernel/sched/completion.c @@ -283,7 +283,7 @@ int __sched wait_for_completion_killable(struct completion *x) bool try_wait_for_completion(struct completion *x) { unsigned long flags; - int ret = 1; + bool ret = true; /* * Since x->done will need to be locked only @@ -292,11 +292,11 @@ bool try_wait_for_completion(struct completion *x) * return early in the blocking case. */ if (!READ_ONCE(x->done)) - return 0; + return false; spin_lock_irqsave(&x->wait.lock, flags); if (!x->done) - ret = 0; + ret = false; else if (x->done != UINT_MAX) x->done--; spin_unlock_irqrestore(&x->wait.lock, flags);