From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965007AbeAXRmr (ORCPT ); Wed, 24 Jan 2018 12:42:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:57764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964850AbeAXRmp (ORCPT ); Wed, 24 Jan 2018 12:42:45 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 962C721717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 24 Jan 2018 12:42:42 -0500 From: Steven Rostedt To: Linus Torvalds Cc: Ingo Molnar , Peter Zijlstra , Peter Anvin , Thomas Gleixner , Linux Kernel Mailing List , linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/urgent] perf/core: Fix lock inversion between perf,trace,cpuhp Message-ID: <20180124124242.5037d0ac@vmware.local.home> In-Reply-To: References: <20180124113629.GS2228@hirez.programming.kicks-ass.net> <20180124153257.kzekv6cjxgk7djkh@gmail.com> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Jan 2018 08:57:10 -0800 Linus Torvalds wrote: > Maybe git should have used a different comment scheme, but I have to > admit that I think this is the first time I've heard of this issue > causing problems in practice. I'm sure it's triggered before, and > nobody has noticed (or I wasn't on the cc). It does happen a bit in practice. It's nailed me a few times. I just consider it as the way git works and didn't complain. > > So the '#' thing _normally_ works, but yes, it can cause issues. I just brought this up here: http://lkml.kernel.org/r/20180112121148.20778932@gandalf.local.home And someone replied with a pointer to: https://github.com/git/git/blob/master/Documentation/RelNotes/2.0.0.txt suggesting git config commit.cleanup scissors Where git looks for: # ------------------------ >8 ------------------------ and does not delete comments before it. But this could play havoc when doing squash though. -- Steve