From: Jamie Iles <jamie@jamieiles.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Jamie Iles <jamie@jamieiles.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe()
Date: Wed, 24 Jan 2018 13:08:25 +0000 [thread overview]
Message-ID: <20180124130825.tjcywfbcdfikklfl@willow> (raw)
In-Reply-To: <1516398795-9018-1-git-send-email-khoroshilov@ispras.ru>
Thanks Alexey!
On Sat, Jan 20, 2018 at 12:53:15AM +0300, Alexey Khoroshilov wrote:
> If clk_get() fails, device_remove_file() looks inappropriate.
>
> The error path, where all crypto_register fail, misses resource
> deallocations.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: Jamie Iles <jamie@jamieiles.com>
next prev parent reply other threads:[~2018-01-24 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 21:53 [PATCH] crypto: picoxcell - Fix error handling in spacc_probe() Alexey Khoroshilov
2018-01-24 13:08 ` Jamie Iles [this message]
2018-01-26 15:46 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124130825.tjcywfbcdfikklfl@willow \
--to=jamie@jamieiles.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=javier@osg.samsung.com \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox