From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933679AbeAXNI3 (ORCPT ); Wed, 24 Jan 2018 08:08:29 -0500 Received: from mail-wr0-f176.google.com ([209.85.128.176]:41591 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933633AbeAXNI1 (ORCPT ); Wed, 24 Jan 2018 08:08:27 -0500 X-Google-Smtp-Source: AH8x226S6t/82Xzpyu78V7AaOWsD4f+fW7F+j01FjpFnCgkQJSKacjmMPKnKm7BL/y7sQEnyWYx//Q== Date: Wed, 24 Jan 2018 13:08:25 +0000 From: Jamie Iles To: Alexey Khoroshilov Cc: Jamie Iles , Javier Martinez Canillas , Herbert Xu , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe() Message-ID: <20180124130825.tjcywfbcdfikklfl@willow> References: <1516398795-9018-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516398795-9018-1-git-send-email-khoroshilov@ispras.ru> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Alexey! On Sat, Jan 20, 2018 at 12:53:15AM +0300, Alexey Khoroshilov wrote: > If clk_get() fails, device_remove_file() looks inappropriate. > > The error path, where all crypto_register fail, misses resource > deallocations. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Reviewed-by: Jamie Iles