From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ak@linux.intel.com>
X-Google-Smtp-Source: AH8x226gw6rJWsVteHKCB4+bQxeWZ/h5mUZQcpb9VH2tpXk63u/OlN96z/jifY3IydnWBkawZgAo
ARC-Seal: i=1; a=rsa-sha256; t=1516808651; cv=none;
        d=google.com; s=arc-20160816;
        b=Lh7WeHMgGTOEKtW1BPw+rlLayG3irTnk/f7MDgyUB2KGaipuMDdrGtwys9rL/+wL5q
         HO8j5p2cRuhjtAJiFwz4b6ZqlYjUGbfOp30ZOVx4MXWheepHCOjRcDgUCT3QB/Xptoal
         jz6uAmqfouW9QpQ8JDRDR4ZSGeSHJ/lCufYY5SfbvBWiu7osT2dO/4a4ktVx6CYM2JVD
         21X5JiAotDJAKVH0EqrJT206NSWXHyfncas2lYLS86waVeHhIQolWwjS8hPhs30SMs9H
         nv2YSXOIWOlH8x7oXOynNcwOsXfMlzCegICOnoLMdMvXU/r4m7N9mwzmX34rvUHWhLKx
         73yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=y/nZ7WWVljG5MgZKounqn/ADRDzT9A/jV5ZWRVMf9nQ=;
        b=T8koMW/5KvhmyMRKEuBmZytAy//IOtXNE/1QaDKdv5vrOPWsiroaiqkOcbVGX6l4Nt
         MiCquCbgWl1yqlQxL41RkyO13IdjwQyHhSNJ36nLsqzXHhXEr80jYaaIHejd8ji/V27M
         WLyzDs9K9vzZgq+jKgUGSDxva7NJ+QS4QgbjAXySb57vXMLLjiuvH6w4FzjZ4E8jijm+
         jw9Lff2JJ9dsM71QJX7uoL7774CbepjEwsDSkD5K+IuzRBiIOUgFuMrDSpV2XHnIMvBi
         4sV1eoJCzD9dOgUQuQDH57P0LXdm5I9JWHCEIFy9YX2ti1ySHkAB5Xn64aACJYvsbBHg
         R3Mg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of ak@linux.intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=ak@linux.intel.com
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of ak@linux.intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=ak@linux.intel.com
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,408,1511856000";
   d="scan'208";a="22246449"
Date: Wed, 24 Jan 2018 07:44:01 -0800
From: Andi Kleen <ak@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Kosina <jikos@kernel.org>, torvalds@linux-foundation.org,
	Thomas Gleixner <tglx@linutronix.de>,
	David Woodhouse <dwmw@amazon.co.uk>, rusty@rustcorp.com.au,
	arjan.van.de.ven@intel.com, jeyu@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "module: Add retpoline tag to VERMAGIC"
Message-ID: <20180124154401.GA26209@tassilo.jf.intel.com>
References: <20180124142817.GA23797@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180124142817.GA23797@kroah.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?=
X-GMAIL-THRID: =?utf-8?q?1590489149252174297?=
X-GMAIL-MSGID: =?utf-8?q?1590489149252174297?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Wed, Jan 24, 2018 at 03:28:17PM +0100, Greg Kroah-Hartman wrote:
> This reverts commit 6cfb521ac0d5b97470883ff9b7facae264b7ab12.
> 
> Turns out distros do not want to make retpoline as part of their "ABI",
> so this patch should not have been merged.  Sorry Andi, this was my
> fault, I suggested it when your original patch was the "correct" way of
> doing this instead.

It's ok for me to revert, but if it's reverted should consider
the warning only patch version instead.

https://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git/commit/?h=spec/retpoline-module-2&id=b40b7c1dbffaa636906b774ef5519882060e1aa0

I had posted that earlier, but reviewers in the end preferred
the simple modversions variant.

I think we should have something at least for 4.15 to catch mistakes.

-Andi