From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: David Lechner <david@lechnology.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()
Date: Wed, 24 Jan 2018 16:19:41 +0000 [thread overview]
Message-ID: <20180124161941.GI9366@sirena.org.uk> (raw)
In-Reply-To: <c7919cd8-447c-6eee-184a-0d40efbcbe75@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On Wed, Jan 24, 2018 at 05:14:50PM +0100, Lars-Peter Clausen wrote:
> On 01/23/2018 11:53 PM, David Lechner wrote:
> > This fixes a possible NULL pointer dereference oops in
> > regmap_name_read_file() when the regmap does not have a device
> > associated with it.
> > - ret = snprintf(buf, PAGE_SIZE, "%s\n", map->dev->driver->name);
> > + if (map->dev && map->dev->driver)
> > + name = map->dev->driver->name;
> > +
> > + ret = snprintf(buf, PAGE_SIZE, "%s\n", name);
> Won't this print "(null)" now? Not sure if that is the best approach.
Indeed. It is an improvement but not exactly helpful.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-24 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 22:53 [PATCH 0/2] regmap: use debugfs even when no device David Lechner
2018-01-23 22:53 ` [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file() David Lechner
2018-01-24 11:30 ` Mark Brown
2018-01-24 16:04 ` David Lechner
2018-01-24 16:14 ` Lars-Peter Clausen
2018-01-24 16:19 ` Mark Brown [this message]
2018-01-24 16:27 ` David Lechner
2018-01-24 17:04 ` Mark Brown
2018-01-24 16:24 ` David Lechner
2018-01-23 22:53 ` [PATCH 2/2] regmap: use debugfs even when no device David Lechner
2018-02-20 12:10 ` Applied "regmap: use debugfs even when no device" to the regmap tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124161941.GI9366@sirena.org.uk \
--to=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox