From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224W35fzWseg4GsZf/WGRvuXsHGEE8RSMzE1duDOP7fqEYdYV6oxZA5xy4ulfYm1Et17FJ13 ARC-Seal: i=1; a=rsa-sha256; t=1516813501; cv=none; d=google.com; s=arc-20160816; b=CmZswDficUc/ptpVhZqJ88h/sxZItHsBvwbqihjmsVgQLrsSOBLh4+wRrnVR6LTsQ7 I3UL11OW4WRjFw8KOmhk8qC4w3/AWeRNsnU9TOPEA3CA9hJiae4nT2iBvB5cnojJUA00 FESXqlc25hRocjTnuAGzFTwAlE5Me2biqLXG5GwCrbc+bwlfaYRaZStU0WLkIEn0bQzR 58CIzs6RL3MB8otOJAdTrS42SSiSEjNHn410UYdAABE804gVB3yFwNms28OSDXuWvrxe 4gdLKhfHqgvjiLG5IIBFG1ct8cZe9ul5QWzcDJB1bkb25KdPLwu15fCmVcs6nEuuVdkU 05yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=uPETuWNFemLQPp1T3dthsIbmkVvPzxEaHWBtUsGSyiA=; b=zBM49u2qBTBN/WtMs/OUZdhecl+kDpm2gPDA97QVz39AOYkeVjAT34mXxBVEGjnCP3 /jeDKl/40zqqHyOf5DZsVKH4bEufEr+aoZ2iKaYprLINekLbBx7VmhOe9EFrrpg8NNw4 /rIcY9EGDfuGibT67yFhn2zxXnvl+L8pgSX0IUp2u4LK1+O95BSI+6PNY43G0J4RaGv/ aAK4TXITX4F3+pY0y3lbFme7eUc/78fSJSxS7TjdJKF/x1NhWvbpW1gM7fgd3ZxnOmJ9 074R0qyl/RK8UqcKAAT6npqCgdgT/TfloT56KagLHTlTLQH241h3UQur507uXuNPfuuq xP4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=gL1gTr0L; spf=pass (google.com: domain of broonie@sirena.org.uk designates 2a01:7e01::f03c:91ff:fed4:a3b6 as permitted sender) smtp.mailfrom=broonie@sirena.org.uk Authentication-Results: mx.google.com; dkim=pass header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=gL1gTr0L; spf=pass (google.com: domain of broonie@sirena.org.uk designates 2a01:7e01::f03c:91ff:fed4:a3b6 as permitted sender) smtp.mailfrom=broonie@sirena.org.uk Date: Wed, 24 Jan 2018 17:04:48 +0000 From: Mark Brown To: David Lechner Cc: Lars-Peter Clausen , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file() Message-ID: <20180124170448.GJ9366@sirena.org.uk> References: <1516748023-17235-1-git-send-email-david@lechnology.com> <1516748023-17235-2-git-send-email-david@lechnology.com> <20180124161941.GI9366@sirena.org.uk> <5920ae0a-bdb7-7819-8e3f-32b20368a20f@lechnology.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9aCKuHbn5v2q3RVc" Content-Disposition: inline In-Reply-To: <5920ae0a-bdb7-7819-8e3f-32b20368a20f@lechnology.com> X-Cookie: Love thy neighbor, tune thy piano. User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590425592886901979?= X-GMAIL-MSGID: =?utf-8?q?1590494233841369914?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: --9aCKuHbn5v2q3RVc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 24, 2018 at 10:27:22AM -0600, David Lechner wrote: > On 01/24/2018 10:19 AM, Mark Brown wrote: > > Indeed. It is an improvement but not exactly helpful. > Would it be better if it said "this regmap does not have driver" instead > of "(null)"? That's both not idiomatically good and isn't even true... ideally we'd be able to get some sort of string out of the user, but otherwise "nodev" or perhaps printing the pointer to the regmap (to avoid collisions if there's more than one of these in a system). --9aCKuHbn5v2q3RVc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlpovK8ACgkQJNaLcl1U h9BQUwf/WoJ9jSsN0bqC+Ob3VhTj1kvMeqcgbb9dzwfiKuIp+eD0H1hewKM0MSys bWCMiDsvEqWLeZdnQCQNLhN0KcC2Zwc6W9RxGnMKfYu5HOzRjnAYNwF+BiqcDwet axz3P0uI88TJAkVIUBwlfWza5Pj8Th3WBfFgaaCxpTQMlxXCUdfd1uV6XlbGBDLe cWVgvOVlwL7hjy9gP/b1CKvTzEehgxj6g/fcI3l+xXq/Es3M+MPdmeY+xN4b80v8 JmK75ZtZL+aHSwgFf1X7Mbg/TF1NZClCIMvLaGGeBG1dnpokgLv/Qu6jLSa2SXCa iGl8lM7QlEjnrtdC5mNEJyYQ8dd3dA== =2ICL -----END PGP SIGNATURE----- --9aCKuHbn5v2q3RVc--