[PATCH] phy: qcom-ufs: add MODULE_LICENSE tag

[PATCH] phy: qcom-ufs: add MODULE_LICENSE tag

[Arnd Bergmann]

While the specific UFS PHY drivers (14nm and 20nm) have a module
license, the common base module does not, leading to a Kbuild
failure:

WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable'

This adds a module description and license tag to fix the build.
I added both Yaniv and Vivek as authors here, as Yaniv sent the initial
submission, while Vivek did most of the work since.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/phy/qualcomm/phy-qcom-ufs.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
index c5ff4525edef..c5493ea51282 100644
--- a/drivers/phy/qualcomm/phy-qcom-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
@@ -675,3 +675,8 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
 	return 0;
 }
 EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
+
+MODULE_AUTHOR("Yaniv Gardi <ygardi@codeaurora.org>");
+MODULE_AUTHOR("Vivek Gautam <vivek.gautam@codeaurora.org>");
+MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
+MODULE_LICENSE("GPL v2");
-- 
2.9.0

Re: [PATCH] phy: qcom-ufs: add MODULE_LICENSE tag

[Arnd Bergmann]

On Wed, Jan 10, 2018 at 5:35 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> While the specific UFS PHY drivers (14nm and 20nm) have a module
> license, the common base module does not, leading to a Kbuild
> failure:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
> FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable'
>
> This adds a module description and license tag to fix the build.
> I added both Yaniv and Vivek as authors here, as Yaniv sent the initial
> submission, while Vivek did most of the work since.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I think this is now the last such warning we get in linux-next.
Kishon, can you pick up my patch for 4.16 so we get a clean
build again?

Thanks,

       Arnd

Re: [PATCH] phy: qcom-ufs: add MODULE_LICENSE tag

[Bjorn Andersson]

On Wed 10 Jan 08:35 PST 2018, Arnd Bergmann wrote:

> While the specific UFS PHY drivers (14nm and 20nm) have a module
> license, the common base module does not, leading to a Kbuild
> failure:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
> FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable'
> 
> This adds a module description and license tag to fix the build.
> I added both Yaniv and Vivek as authors here, as Yaniv sent the initial
> submission, while Vivek did most of the work since.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  drivers/phy/qualcomm/phy-qcom-ufs.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index c5ff4525edef..c5493ea51282 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -675,3 +675,8 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
> +
> +MODULE_AUTHOR("Yaniv Gardi <ygardi@codeaurora.org>");
> +MODULE_AUTHOR("Vivek Gautam <vivek.gautam@codeaurora.org>");
> +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
> +MODULE_LICENSE("GPL v2");
> -- 
> 2.9.0
>