From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932973AbeAXWzd (ORCPT ); Wed, 24 Jan 2018 17:55:33 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38628 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbeAXWzc (ORCPT ); Wed, 24 Jan 2018 17:55:32 -0500 X-Google-Smtp-Source: AH8x225NTIa1PVeT2NtsmLKZ3MiAH3yEbawCJ1kdD9nW8j0SFIv88DxsfAmJGyFili/c5BaGsIObpA== Date: Wed, 24 Jan 2018 14:55:28 -0800 From: Bjorn Andersson To: Arnd Bergmann Cc: Kishon Vijay Abraham I , Vivek Gautam , Subhash Jadavani , Heiko Stuebner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: qcom-ufs: add MODULE_LICENSE tag Message-ID: <20180124225528.GI7250@minitux> References: <20180110163555.613807-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110163555.613807-1-arnd@arndb.de> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 10 Jan 08:35 PST 2018, Arnd Bergmann wrote: > While the specific UFS PHY drivers (14nm and 20nm) have a module > license, the common base module does not, leading to a Kbuild > failure: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o > FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable' > > This adds a module description and license tag to fix the build. > I added both Yaniv and Vivek as authors here, as Yaniv sent the initial > submission, while Vivek did most of the work since. > > Signed-off-by: Arnd Bergmann Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/phy/qualcomm/phy-qcom-ufs.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c > index c5ff4525edef..c5493ea51282 100644 > --- a/drivers/phy/qualcomm/phy-qcom-ufs.c > +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c > @@ -675,3 +675,8 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy) > return 0; > } > EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off); > + > +MODULE_AUTHOR("Yaniv Gardi "); > +MODULE_AUTHOR("Vivek Gautam "); > +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY"); > +MODULE_LICENSE("GPL v2"); > -- > 2.9.0 >