From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
mikey@neuling.org, hbabu@us.ibm.com, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] powerpc/ftw: Document FTW API/usage
Date: Wed, 24 Jan 2018 19:05:52 -0800 [thread overview]
Message-ID: <20180125030552.GB12170@us.ibm.com> (raw)
In-Reply-To: <57a1be39-df84-d678-7560-e2543824472d@infradead.org>
Randy Dunlap [rdunlap@infradead.org] wrote:
> > + struct ftw_setup_attr ftwattr;
> > +
> > + fd = open("/dev/ftw", O_RDWR);
> > +
> > + memset(&rxattr, 0, sizeof(rxattr));
>
> Is that supposed to be ftwattr (2x above)?
Yes. I agree with your other comments as well and will send a new version.
Thanks for the detailed review.
Sukadev
prev parent reply other threads:[~2018-01-25 3:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 2:50 [PATCH 0/5] Implement FTW driver Sukadev Bhattiprolu
2018-01-17 2:50 ` [PATCH 1/5] powerpc/vas: Remove a stray line in Makefile Sukadev Bhattiprolu
2018-03-14 9:27 ` [1/5] " Michael Ellerman
2018-01-17 2:50 ` [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API Sukadev Bhattiprolu
2018-01-17 18:23 ` Randy Dunlap
2018-01-18 16:41 ` Sukadev Bhattiprolu
2018-01-17 2:50 ` [PATCH 3/5] powerpc/ftw: Implement a simple FTW driver Sukadev Bhattiprolu
2018-01-17 18:30 ` Randy Dunlap
2018-01-18 16:45 ` Sukadev Bhattiprolu
2018-01-17 2:50 ` [PATCH 4/5] powerpc/ftw: Add a couple of trace points Sukadev Bhattiprolu
2018-01-17 2:50 ` [PATCH 5/5] powerpc/ftw: Document FTW API/usage Sukadev Bhattiprolu
2018-01-25 0:48 ` Randy Dunlap
2018-01-25 3:05 ` Sukadev Bhattiprolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125030552.GB12170@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=hbabu@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox