From: Jon Mason <jdmason@kudzu.us>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
allenbh@gmail.com, "Hook, Gary" <gary.hook@amd.com>,
Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] NTB: ntb_perf: fix cast to restricted __le32
Date: Wed, 24 Jan 2018 23:13:54 -0500 [thread overview]
Message-ID: <20180125041353.GA9887@kudzu.us> (raw)
In-Reply-To: <CAK8P3a2vp1U1i9-b1vX_FEs-_DGvWx-ut+Z_5hk4R_CxUNiucg@mail.gmail.com>
On Wed, Jan 24, 2018 at 09:07:26AM +0100, Arnd Bergmann wrote:
> On Wed, Jan 24, 2018 at 8:48 AM, Serge Semin <fancer.lancer@gmail.com> wrote:
> > Sparse is whining about the u32 and __le32 mixed usage in the driver
> >
> > drivers/ntb/test/ntb_perf.c:288:21: warning: cast to restricted __le32
> > drivers/ntb/test/ntb_perf.c:295:37: warning: incorrect type in argument 4 (different base types)
> > drivers/ntb/test/ntb_perf.c:295:37: expected unsigned int [unsigned] [usertype] val
> > drivers/ntb/test/ntb_perf.c:295:37: got restricted __le32 [usertype] <noident>
> > ...
> >
> > NTB hardware drivers shall accept CPU-endian data and translate it to
> > the portable formate by internal means, so the explicit conversions
> > are not necessary before Scratchpad/Messages API usage anymore.
> >
> > Fixes: b83003b3fdc1 ("NTB: ntb_perf: Add full multi-port NTB API support")
> > Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
>
> Looks good to me,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied to my ntb-next branch. Thanks for all of the help on this.
Thanks,
Jon
prev parent reply other threads:[~2018-01-25 4:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 17:30 [PATCH] NTB: ntb_perf: fix cast to restricted __le32 Serge Semin
2018-01-19 20:42 ` Arnd Bergmann
2018-01-19 21:03 ` Serge Semin
2018-01-19 21:25 ` Serge Semin
2018-01-19 21:26 ` Arnd Bergmann
2018-01-24 4:18 ` Jon Mason
2018-01-24 7:31 ` Serge Semin
2018-01-24 7:48 ` [PATCH v2] " Serge Semin
2018-01-24 8:07 ` Arnd Bergmann
2018-01-25 4:13 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125041353.GA9887@kudzu.us \
--to=jdmason@kudzu.us \
--cc=Sergey.Semin@t-platforms.ru \
--cc=allenbh@gmail.com \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=gary.hook@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox