From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3480010-1516874388-2-9045783427256523104 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516874387; b=g3TzpInNOaxovn3k6idY9br9UW4So59nbbBHmpKbaP+F4m7 fhX7TM0mSXFmzoCZzduby430Ag4qWRIfMH5M5MC3vo/cMm8VJHKnhpxFtES9I+jW 6AJmHfMzSXmmichjSmL7ZVfVcNvs+SvLQZjy5WjIA4qEt/4qh2+r7uStCAKvQisY 2qMZX9uueOylnQpP+otaI5f2srtaibZi+yw7IOx6qO9dyHNUht0QaUIazLxzOFDC TzBVDCBSvTs5aP1VlfO0Gzc6UyJKBeTOGwG9IgFl3rOLVeft6CrRPFEEtRMMNEt/ bSvnYvMzpht8F9BX3uTZCBiq/I3fq9cPQaZXDuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516874387; bh=3 eyKruFzelAHTlXWpW5ZkKbMfXB/coveHownF/MetG8=; b=SaS9zZsPpdl+8nQk1 fV19qFDRezNLweo8xrj4jnenFwU1y5TTA0mhy2CQrnH7HBrh5mL50Hcd/5i71aub y/5B0bVkDNM8lvdwAGIf3f9q7JaAisDLEplmqapLmot9QdD3rvZ30a7jfmP9BSQ8 hl6ip9KOMvcXsuoRTOp3zYk+7bWJqII3osSuUQl4cRNQfhc7JqGKQCSX8CA/3IP5 WocqAejTm1M/gccNJR/KYXnRJ2MbqbOd2mBbDtRV+tJmdsPMnN9CX97/TEngZCuZ Bif56VCHD9Ip5oQM8HgnUNQ7ok7Br7TKkGVV2VIpzKVnywggKluCU3d1e3Hpgfci hTqTg== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Thu, 25 Jan 2018 10:59:39 +0100 From: Greg KH To: mikelley@microsoft.com Subject: Re: [PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Implement Direct Mode for stimer0 Message-ID: <20180125095939.GA16968@kroah.com> References: <20180122222929.3762-1-mikelley@exchange.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180122222929.3762-1-mikelley@exchange.microsoft.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: olaf@aepfle.de, sthemmin@microsoft.com, jasowang@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, jrp@pun.org, marcelo.cerri@canonical.com, apw@canonical.com, devel@linuxdriverproject.org, vkuznets@redhat.com, leann.ogasawara@canonical.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 22, 2018 at 03:29:29PM -0700, mikelley@exchange.microsoft.com wrote: > +/* > + * If false, we're using the old mechanism for stimer0 interrupts > + * where it sends a VMbus message when it expires. The old > + * mechanism is used if Direct Mode is explicitly disabled > + * by the module parameter, or on older versions of Hyper-V > + * that don't support Direct Mode. While Hyper-V provides > + * four stimer's per CPU, Linux uses only stimer0. > + */ > +static bool direct_mode_enabled = true; > +module_param(direct_mode_enabled, bool, 0444); > +MODULE_PARM_DESC(direct_mode_enabled, > + "Set to N to disable stimer Direct Mode."); Ick ick ick. How is a distro or user supposed to know if/when to enable this and not to enable it? This isn't ok, can you please make this "automatic" to always do the right thing based on what it is running on? Module parameters are not a good idea as they are impossible to maintain and document and use over time. Please never add new ones to the kernel. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel