From: Peter Zijlstra <peterz@infradead.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
linux-kernel@vger.kernel.org,
KarimAllah Ahmed <karahmed@amazon.de>,
Andi Kleen <ak@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Ashok Raj <ashok.raj@intel.com>,
Asit Mallick <asit.k.mallick@intel.com>,
Borislav Petkov <bp@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"H . Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>,
Joerg Roedel <joro@8bytes.org>,
Jun Nakajima <jun.nakajima@intel.com>,
Laura Abbott <labbott@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
rkrcmar@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
x86@kernel.org
Subject: Re: [RFC PATCH 1/2] x86/ibpb: Skip IBPB when we switch back to same user process
Date: Thu, 25 Jan 2018 14:50:55 +0100 [thread overview]
Message-ID: <20180125135055.GK2249@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <86541aca-8de7-163d-b620-083dddf29184@linux.intel.com>
On Thu, Jan 25, 2018 at 05:21:30AM -0800, Arjan van de Ven wrote:
> >
> > This means that 'A -> idle -> A' should never pass through switch_mm to
> > begin with.
> >
> > Please clarify how you think it does.
> >
>
> the idle code does leave_mm() to avoid having to IPI CPUs in deep sleep states
> for a tlb flush.
The intel_idle code does, not the idle code. This is squirreled away in
some driver :/
> (trust me, that you really want, sequentially IPI's a pile of cores in a deep sleep
> state to just flush a tlb that's empty, the performance of that is horrific)
Hurmph. I'd rather fix that some other way than leave_mm(), this is
piling special on special.
next prev parent reply other threads:[~2018-01-25 13:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 0:36 [RFC PATCH 1/2] x86/ibpb: Skip IBPB when we switch back to same user process Tim Chen
2018-01-25 0:36 ` [RFC PATCH 2/2] x86/ibpb: Prevent missed IBPB flush Tim Chen
2018-01-25 8:20 ` David Woodhouse
2018-01-25 16:56 ` Tim Chen
2018-01-25 8:58 ` [RFC PATCH 1/2] x86/ibpb: Skip IBPB when we switch back to same user process Peter Zijlstra
2018-01-25 9:22 ` Peter Zijlstra
2018-01-25 13:21 ` Arjan van de Ven
2018-01-25 13:50 ` Peter Zijlstra [this message]
2018-01-25 14:07 ` Arjan van de Ven
2018-01-25 16:41 ` Peter Zijlstra
2018-01-25 17:04 ` Andy Lutomirski
2018-01-25 18:18 ` Peter Zijlstra
2018-01-25 19:32 ` Tim Chen
2018-01-25 19:34 ` Arjan van de Ven
2018-01-25 19:45 ` Dave Hansen
2018-01-25 20:46 ` Peter Zijlstra
2018-01-25 21:04 ` Andy Lutomirski
2018-01-25 21:57 ` Andi Kleen
2018-01-25 22:01 ` Andy Lutomirski
2018-01-25 23:07 ` Tim Chen
2018-01-26 0:01 ` Peter Zijlstra
2018-01-25 17:24 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125135055.GK2249@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Janakarajan.Natarajan@amd.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=jun.nakajima@intel.com \
--cc=karahmed@amazon.de \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox