From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbeAYPuf (ORCPT ); Thu, 25 Jan 2018 10:50:35 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:40467 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbeAYPud (ORCPT ); Thu, 25 Jan 2018 10:50:33 -0500 X-Google-Smtp-Source: AH8x227qN345ZDv7o34mqlZZ4r7UwqHSJcVlM57kA+ZYWSPDUqEPsZ8EWh2nAZ5TVlDTIGfJ94NUuQ== Date: Thu, 25 Jan 2018 07:50:29 -0800 From: Tejun Heo To: Yafang Shao Cc: guro@fb.com, davem@davemloft.net, longman@redhat.com, lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next] cgroup: support attaching eBPF programs to net_prio cgroup Message-ID: <20180125155029.GG17457@devbig577.frc2.facebook.com> References: <1516894728-2061-1-git-send-email-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516894728-2061-1-git-send-email-laoar.shao@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 25, 2018 at 11:38:48PM +0800, Yafang Shao wrote: > If net_prio is used, we could also use eBPF programs to attach it, > because the net_prio cgroup could be got with prioidx in struct > sock_cgroup_data. > Hence it should not only be limited to cgroup2. I really don't wanna do this. This comes with all sorts of reverse lookup and naming issues. In addition, cgroup1 and 2 aren't mutually exclusive. If the use case is on cgroup1 and wants to use cgroup bpf programs, just replicate the cgroup2 hierarchy for bpf. Hierarchy replication across different controllers is how most use cgroup1 after all. With recent versions of systemd which defaults to using cgroup2 for process management, you get the replication for free too. Thanks. -- tejun