From: Tejun Heo <tj@kernel.org>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: zhong.weidong@zte.com.cn, Jiang Biao <jiang.biao2@zte.com.cn>,
Tan Hu <tan.hu@zte.com.cn>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH V4 1/5] workqueue: rename system workqueues
Date: Thu, 25 Jan 2018 08:01:10 -0800 [thread overview]
Message-ID: <20180125160110.GI17457@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180125155441.GH17457@devbig577.frc2.facebook.com>
Hello,
On Thu, Jan 25, 2018 at 07:54:41AM -0800, Tejun Heo wrote:
> On Thu, Jan 25, 2018 at 03:01:40PM +0800, Wen Yang wrote:
> > Rename system_wq's wq->name from "events" to "system_percpu",
> > and similarly for the similarly named workqueues.
> >
> > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> > Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn>
> > Signed-off-by: Tan Hu <tan.hu@zte.com.cn>
> > Suggested-by: Tejun Heo <tj@kernel.org>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> > Cc: linux-kernel@vger.kernel.org
>
> The patches don't seem split right. There are a number of chunks
> which seem to be in the wrong patch. Can you plesae go over each
> patch and verify that they look, build and run okay?
Just building the same tree structure for different hierarchies. Just
run tree(1) in /sys/fs/cgroup on a systemd cgroup1 system with some
controllers enabled and look at the output.
Thanks.
--
tejun
prev parent reply other threads:[~2018-01-25 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 7:01 [RFC PATCH V4 1/5] workqueue: rename system workqueues Wen Yang
2018-01-25 7:01 ` [RFC PATCH V4 2/5] workqueue: expose attrs for " Wen Yang
2018-01-25 7:01 ` [RFC PATCH V4 3/5] workqueue: rename unbound_attrs to attrs Wen Yang
2018-01-25 7:01 ` [RFC PATCH V4 4/5] workqueue: convert ->nice to ->sched_attr Wen Yang
2018-01-25 7:01 ` [RFC PATCH V4 5/5] workqueue: introduce a way to set workqueue's scheduler Wen Yang
2018-01-25 15:54 ` [RFC PATCH V4 1/5] workqueue: rename system workqueues Tejun Heo
2018-01-25 16:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125160110.GI17457@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=jiang.biao2@zte.com.cn \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tan.hu@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox