Re: [PATCHv1] driver: misc: add Intel Stratix10 service layer driver

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Jan 25, 2018 at 10:39:04AM -0600, richard.gong@linux.intel.com wrote:
> --- /dev/null
> +++ b/drivers/misc/intel-service/Kconfig
> @@ -0,0 +1,9 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config INTEL_SERVICE
> +	tristate "Intel Service Controller"
> +	default y

Unless the machine can not boot without it, it needs to be 'default n'
or no default at all (which is default n).

> +	depends on ARCH_STRATIX10

Why can this not be built on any other configuration?  Why not test
built at the least?

> +++ b/drivers/misc/intel-service/intel_service.c
> @@ -0,0 +1,703 @@
> +// SPDX-License-Identifier: GPL-2.0

Ok, you use SPDX, but then you do this:

> +/*
> + * Copyright (C) 2017-2018, Intel Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program.  If not, see <http://www.gnu.org/licenses/>.

Nothing except that copyright line needs to be there.  Please delete the
rest of the boilerplate crud.

thanks,

greg k-h