From: Sam Ravnborg <sam@ravnborg.org>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: linux-kbuild@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Mutli-directory module Makefiles
Date: Thu, 25 Jan 2018 21:42:17 +0100 [thread overview]
Message-ID: <20180125204217.GA14181@ravnborg.org> (raw)
In-Reply-To: <20180122134607.00d77101@cakuba.netronome.com>
Hi Jakub.
On Mon, Jan 22, 2018 at 01:46:07PM -0800, Jakub Kicinski wrote:
> Hi!
>
> in drivers/net/ethernet/netronome/nfp there is a module which is built
> from C sources in 4 directories. What is the best way to handle that?
Move all .c files to th same directory - like done for almost
all other drives.
In this case we have a directory: drivers/net/ethernet/netronome
which is just an indirection to nfp/
and nfp/ contains a structure with 25 .c files in subdirs.
With some careful renaming everything could reside in
one dir without loosing any structure.
And then the driver starts to look a bit
more like any other driver in the kernel.
And as an added benefit some of the other goodies like
building single files just works.
Sam
prev parent reply other threads:[~2018-01-25 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 21:46 Mutli-directory module Makefiles Jakub Kicinski
2018-01-25 13:08 ` Masahiro Yamada
2018-01-25 19:47 ` Jakub Kicinski
2018-01-27 22:28 ` Masahiro Yamada
2018-01-25 20:42 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125204217.GA14181@ravnborg.org \
--to=sam@ravnborg.org \
--cc=kubakici@wp.pl \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox