From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227EKkpXvnzzPG8BTmGNr9tOkv50/wM5wSkLKEj6bs+u9+oe7tdIIXemPOsgce3FmtNapsYd ARC-Seal: i=1; a=rsa-sha256; t=1516916805; cv=none; d=google.com; s=arc-20160816; b=qftBdPt9Nj+Tkj8YmjSm9ro8sSIfjOD2jOW8983VKsBdX8gmfT61tXNix3EsaURm2l 13U8O7IAUojM2GFKNSoohbDm5eE3fpfHv1Jae6BCx5uegcIa8xRAoKMNtXSJ9h9KTCB1 ey8lNSrkTdClgkZAYX1tVThMwnB7KRda30xvZf5ftgK27D9oExrEORwr3MNo7x+a502F YZLx8z64cH0p0cpSt3hOmDjBfL4n7VsX2IMJNsfx6mlMabOWJ2TBdTYzrnwPBowybvWn YIgiomFUQ+5t3y/UR61pd5phcFU/zBbN8rc4wdyIRREcJTSANrsWShR5Nk1rRPcQmi1v KdgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=JG47TsbjGp6VFJmXv14YbMVGOyEpmRAHuIj/HRKKG24=; b=mhGvqGo2EZeZNXNILBvtPiB5yvsJpBo6BBFLaAHYo+p8tP2zcrt5cNBHH1LnSdZ36R 562bJIV68JDBfsg5hgBmZfc+aUhVKCxeKYmUf3DjAhYtd4NSxT3lZPf68N2uQBVZXS3G kgu9PS/tX4n7GKkj1DmY0mTSrXOYu5Nthtu76M9mZfbwDDJpP3rDGuD9g6QCgBqYAMgh eWTRlShqudSTmqETuCtbC3+YjBjjNRnQwic4uBQwBVVloWs6tEnteihS/69gV67GjI4A QWq3o5iUOiA8imJt/cr1mePkYymHzwUbRGXeLt62tFHkLJ4feiYzEjnmvwyH46eol7GN vjVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=hBqHMW6m; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=hBqHMW6m; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Thu, 25 Jan 2018 13:46:43 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove redundant dev_err messages on device_create Message-ID: <20180125214643.GB24122@fury> References: <1516826019-124903-1-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516826019-124903-1-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500036473711477?= X-GMAIL-MSGID: =?utf-8?q?1590602556384729661?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 24, 2018 at 08:33:37PM +0000, Vadim Pasternak wrote: > The upper layer will manage and report errors returned by the create and > destroy functions. > > FIXME: but it doesn't - we don't even check I think we agreed to just drop this patch entirely, since this error is not checked elsewhere? Keeping the dev_err messages? > > Signed-off-by: Vadim Pasternak > Acked-by: Andy Shevchenko > [dvhart: refactored into smaller functional changes] > Signed-off-by: Darren Hart (VMware) > --- > drivers/platform/mellanox/mlxreg-hotplug.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c > index e55f576..0ccd327 100644 > --- a/drivers/platform/mellanox/mlxreg-hotplug.c > +++ b/drivers/platform/mellanox/mlxreg-hotplug.c > @@ -187,16 +187,11 @@ static int mlxreg_hotplug_device_create(struct device *dev, > struct mlxreg_hotplug_device *item) > { > item->adapter = i2c_get_adapter(item->bus); > - if (!item->adapter) { > - dev_err(dev, "Failed to get adapter for bus %d\n", > - item->bus); > + if (!item->adapter) > return -EFAULT; > - } > > item->client = i2c_new_device(item->adapter, &item->brdinfo); > if (!item->client) { > - dev_err(dev, "Failed to create client %s at bus %d at addr 0x%02x\n", > - item->brdinfo.type, item->bus, item->brdinfo.addr); > i2c_put_adapter(item->adapter); > item->adapter = NULL; > return -EFAULT; > -- > 2.1.4 > > -- Darren Hart VMware Open Source Technology Center