From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226rIU0snUbkqXywzu8JJeGuHxUbqdcHGJkc8VsCjyIFm1gp+wlKZbZ38JWHQw5am2C2lRkV ARC-Seal: i=1; a=rsa-sha256; t=1516918415; cv=none; d=google.com; s=arc-20160816; b=D+v4kgIyR0DsOtU39gtyaypkpgP7stbCi66Vc8xGkbr5Kj6MY4hEG5L0EWBYqvL4tW SeJkHklDORPZpXW/PMQj16x7fOh8UvBLy/c/jiTqBYFSmVByKzwO5QN7pkORylaqQ77e W/9bxym28M97tmMU2BJXT2Jlwycf9kqaP1mzt/ip+DXRuuufO1Ae9D3L4crnacwOdIh5 o6rnPHQQKQhgRSRxCbXx4iIHo4Hx6HOGB+Bc0VDuR0U8WPkDjaBkSc1VC1dAnyyDMHTi Rc3dMolPSYq+Tdv2SPS5WFwjhoui1xE+QGo/GZ27j+GarzwBh1AegVCzaWa6AZyMYuya F5hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=5t8OrRU0H5/wx6OcoJBOFNidwW9aV+/P34MhOT/HMCQ=; b=KTtVevGUA+8cFoHmU4cKZVDPam29s9O9Q3ZWaJJC9NrUPh7VyiSdro39OXUJul7CAd n30pAbjkkwi8T68sd0OBJGLY5Ct2SZ40p0Vgk2cDgPSezFdYTrSAfSiqB2ZZ8Y7HGlbm pSgRj/W47UIyml5zSP6sXUGLgEoQO3hoimZ+hvrnqcGGT6QxyIAUFaykr7E6tnuOOPea qCLmzdilB14lnIzO3mf5if8llqSg0fq2OgzIu1+J1/iZxs4za+HW36YhGzB/+iN+ahmr cBMzhYHey/v9blxsCBYLXxFCm3vFvbcKoZm1QZUYS2KN7CyyRgZEXWix9cNjiUMnwe3O NKcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=hGGNAEZ3; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=hGGNAEZ3; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Thu, 25 Jan 2018 14:13:32 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v11 09/12] platform/x86: mlx-platform: Simplify IO access to regmap context Message-ID: <20180125221332.GC24122@fury> References: <1516826098-125036-1-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516826098-125036-1-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500111879646764?= X-GMAIL-MSGID: =?utf-8?q?1590604244753390134?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 24, 2018 at 08:34:55PM +0000, Vadim Pasternak wrote: > Get rid of struct mlxplat_mlxcpld_regmap_context, which contains only the > field with base address. Instead obtain base memory address by > devm_ioport_map to local variable and pass it to devm_regmap_init. > > Modify mlxplat_mlxcpld_reg_read/write to directly use pointer to context > for IO operations. > > Add missed description of pdev_hotplug for struct mlxplat_priv. Separate patch. Keep in mind that if there is a bug, and a patch is reverted - do you want it all reverted together? In this case, the comment is totally unrelated to this change. I've made this change. -- Darren Hart VMware Open Source Technology Center