From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227ltZOWUb8UFICGvITekYVw/fsODiCY9quNMsL7CQRtCQoWPMRO/C39I11dbbOqCRPpnILb ARC-Seal: i=1; a=rsa-sha256; t=1516918602; cv=none; d=google.com; s=arc-20160816; b=VCbr/GNV3ordk8/VVxgfwIVZSn4Cur/9Ek9PL76ech6d+B7w7cKLEeRtVoMMno0FUp RilU+emhxR/FyV83ZpMDzQBiwvw4NxnePqVbFnUu4vFJq5a0SQDYGImlyS5JW1VPS7/x R5jI/c2bHcBFQrxNnyyOzMV2mXt9jdDk0JwCL/BpDsH+xRdbRszsMax+egApvBCaIHMk q4AwoxLaQs47gTGpU56a8nEDqDhnfytRVfJcS+/I94gBHBzancWTmJ8rrBTfO/MiNRKt uAscP6CjGZ+2fKiZcvN2dWYfmG27PLsKpUlwe+CxwDMp5HRWp+fxGsBaFXFF+gYi/uL9 KJVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=918x3kfYjJFVrn59jr8OLnAY3d9yK2RkTLVvELnAlcI=; b=zKY/Py72CsR7NfLFFf1NYXppifbCrYHz5YU3OK4gP0cHgRRhT+P6nSsDHDNZc0ZcD8 ti095wiQrgMqhpXuDQxTnl03Ai7OeciZXdSfszb8HedX6SoNN3/lrcKJCTWjAFDMxBhp k4CswpFSTMVD8ipkk/juY9cd9OP2bayJYDFrVG4pjCBYACQCUnoCjBfREUbkE+fCSz1d mhMuosvK2OPlXikBW2gazNhEbY1SQ2ZUOszKIoOoCVzhdLlIqOh3vTU58Nk2JBonjk5z cBHuHbog9GrOil/8GiGesg36vkBKVp0Mf536c4CGdwdN63qpI9VM+etYpOFD2yr8JBiU TC8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=c9XJCjYj; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=c9XJCjYj; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Thu, 25 Jan 2018 14:16:39 -0800 From: Darren Hart To: Vadim Pasternak Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us Subject: Re: [patch v11 11/12] platform/mellanox: mlxreg-hotplug: Add check for negative adapter number value Message-ID: <20180125221639.GE24122@fury> References: <1516826098-125036-1-git-send-email-vadimp@mellanox.com> <1516826098-125036-3-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516826098-125036-3-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500118231102457?= X-GMAIL-MSGID: =?utf-8?q?1590604439861991323?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 24, 2018 at 08:34:57PM +0000, Vadim Pasternak wrote: > Verify before creation of hotplug device if the associated adapter number > is negative. It could be in case hotplug event is not associated with > hotplug device. > > Signed-off-by: Vadim Pasternak > --- > drivers/platform/mellanox/mlxreg-hotplug.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c > index b891ec7..c806451 100644 > --- a/drivers/platform/mellanox/mlxreg-hotplug.c > +++ b/drivers/platform/mellanox/mlxreg-hotplug.c > @@ -95,6 +95,14 @@ struct mlxreg_hotplug_priv_data { > > static int mlxreg_hotplug_device_create(struct mlxreg_core_data *data) > { > + /* > + * Return if adapter number is negative. Return if adapter number is > + * negative. It could be in case hotplug event is not associated with First sentence repeated twice. I've corrected this. -- Darren Hart VMware Open Source Technology Center