From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3581720-1516995581-2-10911597909888354901 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.136', Host='smtp3.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516995580; b=fe9N/v2N0j1NJkW6E5kVk9LmHDwUUH7onZTPEX/JUFIqdtp KW5fRFurfg0/Cc25hsWrPZKu0f9thcmHRVuLUGLh1eaYESdFUB9nbsX0e8u1/iGH NbHgosulAKCQTI2WwfIZzCScjAKPIS6P1cD7et39/pvFw1+sUDvbU4U08vFDAL2T vo8cxCj9RWfg7HsmZ+7eXcs9DIodKUTqy7nXW2Yf4cYS/NuPbDfWzSjK7pz4J21y LJ47kNaCxICBl48sxXnpG2Y6V2mvvDYo6Ju6y5Ixa23W54/2Ufk1RjCyc1cQEzjT 7vD2ioLKVSJg1iT28C/R8w1Hx0hu1d6NImU5QoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516995580; bh=z 6u+aoMH2rycsmh5gEx+3IiUTaE54ziCVTGDQrKd2oQ=; b=ka4YHuzli62x5txXH pOmGPwM7Udb9tMTMJ8NlT2TuQVyHlkyvQ0Ko9rQz9fVeUX0kIzZjMHfRHA/ElOHQ AgNWsVm3DT7MPnPu1H78v4UW43nw6cVcTyWBafOA6bEqJmKBqsMo/9BchAje+wVB XsH5ElqBnZX2189Baii7lFIhz8nj3qLCI+6Lx942rHHDzGo3gyU/CyeDWECxfNGW VLRPYWPZirQEfnDyOZtnQQ00E27KeSLs6x1eSuav/YR7duQDdnbOnrc7G7ojZnJd AtVxqRvUySyAtFLm/nSpoNEuYHPKuhYg5ahjS1H/mBiAZyYO5TAYti35waYpqq+c ZXMiQ== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Fri, 26 Jan 2018 19:15:39 +0100 From: Greg KH To: "Michael Kelley (EOSG)" Subject: Re: [PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Implement Direct Mode for stimer0 Message-ID: <20180126181539.GA29801@kroah.com> References: <20180122222929.3762-1-mikelley@exchange.microsoft.com> <20180125095939.GA16968@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "olaf@aepfle.de" , Stephen Hemminger , "jasowang@redhat.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "jrp@pun.org" , "marcelo.cerri@canonical.com" , "apw@canonical.com" , "devel@linuxdriverproject.org" , "vkuznets@redhat.com" , "leann.ogasawara@canonical.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 26, 2018 at 05:34:28PM +0000, Michael Kelley (EOSG) wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Thursday, January 25, 2018 2:00 AM > > To: Michael Kelley (EOSG) > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > > apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com; > > leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen Hemminger > > ; KY Srinivasan ; x86@kernel.org; > > jrp@pun.org > > Subject: Re: [PATCH v2 char-misc 1/1] Drivers: hv: vmbus: Implement Direct Mode for stimer0 > > > > On Mon, Jan 22, 2018 at 03:29:29PM -0700, mikelley@exchange.microsoft.com wrote: > > > +/* > > > + * If false, we're using the old mechanism for stimer0 interrupts > > > + * where it sends a VMbus message when it expires. The old > > > + * mechanism is used if Direct Mode is explicitly disabled > > > + * by the module parameter, or on older versions of Hyper-V > > > + * that don't support Direct Mode. While Hyper-V provides > > > + * four stimer's per CPU, Linux uses only stimer0. > > > + */ > > > +static bool direct_mode_enabled = true; > > > +module_param(direct_mode_enabled, bool, 0444); > > > +MODULE_PARM_DESC(direct_mode_enabled, > > > + "Set to N to disable stimer Direct Mode."); > > > > Ick ick ick. How is a distro or user supposed to know if/when to enable > > this and not to enable it? This isn't ok, can you please make this > > "automatic" to always do the right thing based on what it is running on? > > To be clear, this patch already does the "automatic" thing based on the > capabilities of the hypervisor. But it's often handy to be able to override > the automatic behavior without having to rebuild the kernel. Then put the option somewhere else. sysfs, debugfs, somewhere else. Never a module parameter please, not for new code. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel