From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joel Fernandes <joelaf@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Todd Kjos <tkjos@google.com>,
Arve Hjonnevag <arve@android.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] ashmem: Fix lockdep issue during llseek
Date: Fri, 26 Jan 2018 19:39:55 +0000 [thread overview]
Message-ID: <20180126193954.GB13338@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAJWu+oo+Y4eNTX+vMceYTB-FF5A190OHP7yPKkDGYH-jTqSsmQ@mail.gmail.com>
On Fri, Jan 26, 2018 at 11:23:47AM -0800, Joel Fernandes wrote:
> I was just trying to be careful with the least intrusive solution
> since I'm not the original author of the driver.
Sure, but that needs a proof that it *is* a solution...
> But one usecase for the mutex is with concurrent lseeks, you can end
> up with a file->f_pos that is different from the latest update to
> asma->file->f_pos. A barrier could fix this it too though. Any
> thoughts?
lseek(2) is serialized against lseek(2) and read(2) on the same struct
file - see fdget_pos() for details.
ashmem_mutex really does look like an overkill - something much lighter
should serve just fine...
next prev parent reply other threads:[~2018-01-26 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 2:46 [PATCH] staging: ashmem: Fix lockdep issue during llseek Joel Fernandes
2018-01-26 3:13 ` [PATCH] " Al Viro
2018-01-26 19:23 ` Joel Fernandes
2018-01-26 19:25 ` Joel Fernandes
2018-01-26 19:39 ` Al Viro [this message]
2018-01-26 20:45 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126193954.GB13338@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arve@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox