From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226aqLDg11Kco0hqc552EDIq+CaVm7xDOvUUE8Dsmypaq2cNT7lRGZrLirC3jSqkSGMrusR6 ARC-Seal: i=1; a=rsa-sha256; t=1517010081; cv=none; d=google.com; s=arc-20160816; b=FMms+NB2v+Ew+4KLL2Kc9iREEuGF4WEomkpN1A7xFljwLyCLc7nNudYLJXdxlBtbt3 7Z579re1suqX7hQadLcJwUzbMDmSDdFbi0PFZHFs6vS0Z/KLrbC1zPtdaibQ6POSAK/3 An/HDQ8XwrBRWo8yEeRL4dEpMDoXZFmkq2Od0X4Y6t88+Tp13vL68wUsWPpijQFRutJV pPqedIkgDLXstmw8g4Igfp3m6gqgAvnqLlPMc4OwhIxQk+TLCpJ/wbmTptHwxcs9fCh8 koyTsTjRfnnogcSleSHTbKeB5w0HMXImfM84eBthgDS0mAAn+oHGaMH7D6mfqNStqPaL qzEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=I6zeKC6giuZW3tCyLjpEe1JYOcIbtd4eHdlJG+IlcsY=; b=ByTnJp6VJW0Fbob2o/e0R1wlojcT610Jq+A44wl/GF3Joovnhu6kqFJETZIewwBxCN HNo+77dkH3RB4JVfvwFDZ+roZD4OzmR9hXDU2p1J2DAk8n4PgadsEcq/X0CeVbbDW1a1 nzqOVVfTe+rLL/tCIKI+76MLuP4bGM/TIElpAFdlz3UiYGMnXGhACs9C0yOtzjbllo3p oX/wB1ziJedv0G5p/FmfqFpuCmpa/87u+md+hliliz5+NFUdCg+CD3M2cvGO6we+zI9X vM2+Wcd8Mbax73POu117lGQDWGzWhI1cGXLF2IazIBkvT+R4w9CDjD9guHHWisTc6ou6 GW0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=GPIETsPE; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=GPIETsPE; spf=pass (google.com: best guess record for domain of dvhart@infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=dvhart@infradead.org Date: Fri, 26 Jan 2018 15:41:17 -0800 From: Darren Hart To: Vadim Pasternak Cc: "andy.shevchenko@gmail.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove redundant dev_err messages on device_create Message-ID: <20180126234117.GB3736@fury> References: <1516826019-124903-1-git-send-email-vadimp@mellanox.com> <20180125214643.GB24122@fury> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590500036473711477?= X-GMAIL-MSGID: =?utf-8?q?1590700362991635771?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 26, 2018 at 04:59:32PM +0000, Vadim Pasternak wrote: > > > > -----Original Message----- > > From: Darren Hart [mailto:dvhart@infradead.org] > > Sent: Thursday, January 25, 2018 11:47 PM > > To: Vadim Pasternak > > Cc: andy.shevchenko@gmail.com; gregkh@linuxfoundation.org; linux- > > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; jiri@resnulli.us > > Subject: Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove > > redundant dev_err messages on device_create > > > > On Wed, Jan 24, 2018 at 08:33:37PM +0000, Vadim Pasternak wrote: > > > The upper layer will manage and report errors returned by the create > > > and destroy functions. > > > > > > FIXME: but it doesn't - we don't even check > > > > I think we agreed to just drop this patch entirely, since this error is not checked > > elsewhere? Keeping the dev_err messages? > > > > Yes, we'll keep it. > We just had conflict in patch order and I wanted to fix it, staying as much as > possible aligned with the top of mellanox v10 branch. > > However currently we still have a problem in mellanox v11 after patch > platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface > It dropped parameter device in mlxreg_hotplug_device_create, which is > Used inside the routine. > > I'll send a separate patch to fix it from top of v11. In other case it'll be > necessary to fix Modify to use a regmap interface and re-send all from > 5-th patch in series. > > Also we should drop the patch: > platform/x86: mlx-platform: Simplify IO access to regmap context > It introduced the issue reported by sparse. > > I am resending two last patches from review-dvhart-mellanox-v11 branch > and also patch with fix for mlxreg_hotplug_device_create, as: > 0010-platform-x86-mlx-platform-Extend-register-map-config.patch > 0011-platform-mellanox-mlxreg-hotplug-Add-check-for-negat.patch > 0012-platform-mellanox-mlxreg-hotplug-Fix-issue-of-commit.patch > > Thank you very much for your help, OK, please see review-dvhart-mellanox-v12 on infradead or github. I've verified this passes a clean C=1 (sparse) build at each patch. I believe this is in a state that can be moved to testing. Please confirm. If you still want to move the dev_err messages out of the create function, we can do that separately. Let's get this merged so we can move forward. -- Darren Hart VMware Open Source Technology Center