From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-424359-1517030239-2-1530902370843221433 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517030239; b=eKoQZP3HjroFHVBy70PB8cVwZae5qcChhcVE7qz2enl90sT iELNd2zNySUCjPKX/XJFS3WIa/V66C/Hk1o65oxEEPdDo5A6seNItkzpwpzV9kXq wqBcEudL7MaGiLHOl+mMXES4SatoE2fZp/4+SeObxr07lnqvvD5qv/X8Qd30sNA8 WU3cih677MzG0Qs7XPZ7yHpZ/HRgNlP0s+JRJq+oLXfYddSoAGIVW7Wc7HkmMFK4 t8r/lQESY7Xxtu1rxD96tRf35QfCZMTDuMop2apl26PUXN/COWSmDLrhAPWRUKFl FdCY+urefLzFacaefYBhaNVhbBFl+a58Ajsti1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1517030239; bh=hqW8joZwz1EfYOdQD5g9syCogo q7uqLt3tc9wfSY7zk=; b=VcJHRgKAMPS7b2jHOgKunHtyPJ1ehNOA/WjkB2tmz/ P2wJ11vOO/aFNMc3zRrNWuLWOiXvyUodPFnY1OEcB3YgiaUGRHQ32d3szUv1xok2 hKIf2QCeRFK/rtcsc9zxgrSuzqLaznZ+c9Z9Az/sphF3dn2MLLk+a/Db000JX9L0 QkvxhxwAwv5/X/tT9Q2cTDFZRKwWZl7mqNY74qD9FL+sF9vFB56MGGZOPiRwK1TX waJBntP32pf5/KOBTdzhr0p8farX0en2YJ+LdroIw77I1YnG45JmYg0ADbzATlQQ 2US1p9GiX3tcBj3Oj0pCVJLnQRo7kBopCsYRId8A/QNw== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=o+Za4/Nv x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=FjSd6pCy; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=o+Za4/Nv x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=FjSd6pCy; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464AbeA0FRN (ORCPT ); Sat, 27 Jan 2018 00:17:13 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:33306 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbeA0FRM (ORCPT ); Sat, 27 Jan 2018 00:17:12 -0500 X-Google-Smtp-Source: AH8x225YxO27FAl96WpGMzw/Zh9ix7z7OS0t3yToNDkFBr9OY9ot3FsglVC516Vv2k4MZ2OQwyRxuw== X-Google-Original-Sender: Date: Sat, 27 Jan 2018 16:16:24 +1100 From: Johan Hovold To: Colin King Cc: Greg Kroah-Hartman , Felipe Balbi , Johan Hovold , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: wusbcore: remove redundant re-assignment to pointer 'dev' Message-ID: <20180127051624.GA11128@localhost> References: <20180126150712.6380-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180126150712.6380-1-colin.king@canonical.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 26, 2018 at 03:07:12PM +0000, Colin King wrote: > From: Colin Ian King > > Pointer dev is initialized and then re-assigned with the same value > a little later, hence the second assignment is redundant and can be > removed. > > Cleans up clang warning: > drivers/usb/wusbcore/wa-nep.c:88:17: warning: Value stored to 'dev' > during its initialization is never read > > Signed-off-by: Colin Ian King Reviewed-by: Johan Hovold