From: Jason Gunthorpe <jgg@ziepe.ca>
To: Joe Perches <joe@perches.com>
Cc: Corentin Labbe <clabbe@baylibre.com>,
dledford@redhat.com, hal.rosenstock@gmail.com,
sean.hefty@intel.com, swise@chelsio.com,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/cxgb3: remove cxio_dbg.c
Date: Sun, 28 Jan 2018 14:09:03 -0700 [thread overview]
Message-ID: <20180128210903.GL23869@ziepe.ca> (raw)
In-Reply-To: <1517156662.765.10.camel@perches.com>
On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote:
> On Sun, 2018-01-28 at 15:11 +0000, Corentin Labbe wrote:
> > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups")
> > 10 years after, we could remove it.
>
> OK, now you could remove the prototypes and probably
> CONFIG_INFINIBAND_CXGB3_DEBUG too.
>
> There is a DEBUG test and many uses of pr_debug
> that would have modified behavior.
>
> The pr_debug uses would only be emitted via a
> dynamic_debug enable and the #ifdef DEBUG is
> probably not necessary or useful as it guards
> a BUG_ON.
>
> drivers/infiniband/hw/cxgb3/Kconfig | 9 ---------
> drivers/infiniband/hw/cxgb3/Makefile | 2 --
> drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 ---------
> drivers/infiniband/hw/cxgb3/iwch_cq.c | 7 -------
> 4 files changed, 27 deletions(-)
Yes, can you resend the patch with Joe's hunks as well?
Thanks,
Jason
next prev parent reply other threads:[~2018-01-28 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 15:11 [PATCH] IB/cxgb3: remove cxio_dbg.c Corentin Labbe
2018-01-28 16:24 ` Joe Perches
2018-01-28 21:09 ` Jason Gunthorpe [this message]
2018-01-30 8:23 ` LABBE Corentin
2018-01-28 18:27 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180128210903.GL23869@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=clabbe@baylibre.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox