From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1452603-1517181436-2-15495383599138010121 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES roen, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517181435; b=CY0cJKS6x6MLooZ2F1THqgbRuVxxLS5Cdsso5mzULroHW0h sLUGvr9mGyz3kY7TrwxHOpGqR+obek8H3HIIo+BGWpfPVrAJDxzOtSJ/CVUJ4ZdM ZDy1vbs9dASyZL/JIjBpKdkspH1ohpaOUBeCSA55UqmtqoJG67p1slXheKizKAHF /CQJJRYtQT64k4W0Wj1te7bdglI/OM39YospxdWhoT/iDWmBUVuBKjqmAE8b8W7R WXlOIJ9lzs+Xsr+BFFyUR2lNiIlkj/Xg2HowCHgJMhG2Dr1apZ5MGs0tnzuKFVJT hcFRhDZNYDe5LDFVCNUQiau4bEHtEMg8oziI8Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517181435; bh=nd5zsn zdgC6KgV1G7sVirA+yy4rnc/INh1SHQtlsWu0=; b=S/MMpxxDm0dlYyXQDBveG/ 9wR0PDfJBSpDpAp4lIz3ZmDX/wQYopjc8AzjjF9/RKAHZhtTkOuOawwgWDzVyf4j fZontFBg9u5eTO4C/JcLNq8JP/V2e+tNl8b35Sz2z5iylCTZOL2F/LBDy+gOYdQ+ it7aFS7oYFoGt17sjBwkfrljnJl7ky2n2GY75hfGX877WfezLx7DoDHGjwgOoCh/ tNa4JN1Gz3OIXX/Rl8rd/gO2BAD+E3tz51fbGlPpqDANlNWEw85+CCam/N2yY795 FKr7HpxtiaoHqJcAVUUQtIvjd1uulWA05FYgWm1NNqSUqetwTpAyKlHdgGgiIdBw == ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=VwWSQi8n x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=VwWSQi8n x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbeA1XQs (ORCPT ); Sun, 28 Jan 2018 18:16:48 -0500 Received: from mail-by2nam01on0099.outbound.protection.outlook.com ([104.47.34.99]:35296 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751964AbeA1W0L (ORCPT ); Sun, 28 Jan 2018 17:26:11 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Jiri Olsa , Adrian Hunter , Andi Kleen , David Ahern , "Namhyung Kim" , Wang Nan , "Arnaldo Carvalho de Melo" , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 015/100] perf top: Fix window dimensions change handling Thread-Topic: [PATCH AUTOSEL for 4.14 015/100] perf top: Fix window dimensions change handling Thread-Index: AQHTmIb9Cb4rFe6Vm06RGUXtHL2QvQ== Date: Sun, 28 Jan 2018 22:26:07 +0000 Message-ID: <20180128222547.7398-15-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1004;7:k6BS25IDH4neYdIR0198jfqCjeCKGJS2TIeAlkG7wcNk0TkIvRYguoKfYdqfp1zqsViV1Jj9byN5qAAOeSovDBH97udL/ZkQr1O84+H/lE1mxNf1rk2zgvn/J+ezXlh793sGYjz6nLgGiKA3DutjdHJUPw9TB3HvIoR3ppoip5gjeonkUGCGRzRMCTYZYKuaIxyqfR06yiy2ohv7Kv5beN8lZFtFOKSfshnhx1d4mPLuaEnfNpVBVlSuFRNG1pWw x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(346002)(396003)(376002)(39380400002)(39860400002)(366004)(199004)(189003)(2501003)(6486002)(186003)(110136005)(5660300001)(106356001)(97736004)(68736007)(6512007)(5250100002)(6306002)(316002)(53936002)(66066001)(99286004)(2950100002)(575784001)(86362001)(54906003)(22452003)(6436002)(26005)(102836004)(59450400001)(25786009)(10090500001)(76176011)(8676002)(10290500003)(14454004)(6506007)(86612001)(8936002)(81156014)(2900100001)(81166006)(1076002)(107886003)(478600001)(3280700002)(39060400002)(2906002)(72206003)(7736002)(305945005)(105586002)(36756003)(3846002)(3660700001)(6116002)(4326008)(966005)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1004;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c2f642b4-6d2e-4fd8-867d-08d5669e210e x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1004; x-ms-traffictypediagnostic: MW2PR2101MB1004: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(50582790962513)(85827821059158)(42068640409301)(84791874153150)(104084551191319)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:MW2PR2101MB1004;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1004; x-forefront-prvs: 05669A7924 x-microsoft-antispam-message-info: d5OhYh/kAtkX+73UIpMp32aT+qJIG8VSAPae8ym6prTPa9HA6TLJOy9U3jrxbWVcJaof7fLClA9dUBhES6R/nw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2f642b4-6d2e-4fd8-867d-08d5669e210e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:07.2297 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1004 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Jiri Olsa [ Upstream commit 89d0aeab4252adc2a7ea693637dd21c588bfa2d1 ] The stdio perf top crashes when we change the terminal window size. The reason is that we assumed we get the perf_top pointer as a signal handler argument which is not the case. Changing the SIGWINCH handler logic to change global resize variable, which is checked in the main thread loop. Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Tested-by: Ravi Bangoria Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-ysuzwz77oev1ftgvdscn9bpu@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/builtin-top.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index ee954bde7e3e..dd57978b2096 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -77,6 +77,7 @@ #include "sane_ctype.h" =20 static volatile int done; +static volatile int resize; =20 #define HEADER_LINE_NR 5 =20 @@ -86,10 +87,13 @@ static void perf_top__update_print_entries(struct perf_= top *top) } =20 static void perf_top__sig_winch(int sig __maybe_unused, - siginfo_t *info __maybe_unused, void *arg) + siginfo_t *info __maybe_unused, void *arg __maybe_unused) { - struct perf_top *top =3D arg; + resize =3D 1; +} =20 +static void perf_top__resize(struct perf_top *top) +{ get_term_dimensions(&top->winsize); perf_top__update_print_entries(top); } @@ -477,7 +481,7 @@ static bool perf_top__handle_keypress(struct perf_top *= top, int c) .sa_sigaction =3D perf_top__sig_winch, .sa_flags =3D SA_SIGINFO, }; - perf_top__sig_winch(SIGWINCH, NULL, top); + perf_top__resize(top); sigaction(SIGWINCH, &act, NULL); } else { signal(SIGWINCH, SIG_DFL); @@ -1022,6 +1026,11 @@ static int __cmd_top(struct perf_top *top) =20 if (hits =3D=3D top->samples) ret =3D perf_evlist__poll(top->evlist, 100); + + if (resize) { + perf_top__resize(top); + resize =3D 0; + } } =20 ret =3D 0; --=20 2.11.0