From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224CyRPi6gjawvMeEckYHyOnP67t+1OKI+jXHkeoXbQrvUf4zFBiLDctxMC7D/25Yx0eWPrP ARC-Seal: i=1; a=rsa-sha256; t=1517178361; cv=none; d=google.com; s=arc-20160816; b=OvJ6inTP4zwzFdUCgIIDskoQInsRgLKl0lzJJpqYz7gjma2vvmVOr1CIStNbCI9OI/ KeqzqpNRXTDajy8z9ADD8HIwZKLDTLJgBiQbWC42zugV2C3n6bnKX312IcuBODO9Dqla uQxlwfecj/VMUoP7MBXqXLerFdZI3LPwZHM4Qv2nOT1OOLJg99wFJBvgPwo/KqqAdlBt 4E0Zd4m+QVeb5hJxR84h+lP4x1EGs9pdNnaSmpGD4HiwQKcEx5xhvdwNPztTHWyp690a rB/fQEUCybgnMEAJ8BwJSsKD/akGixO/9922LTgZWr+XvtF3Nw2uM+jET5pVhO8t7t6X u15g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=K+enRBO9HvrbYaONHYB6RSSYhqNf01Z654ol78mB7SQ=; b=ORpVwYZrHOTKaNSh2IXfuVPnFonCyjKHmoQn2cnlMCVX8yRKafN87gbd6/juhaewI/ N7RiXVLadYCCfiIJ+L01F5MIRQH27vt7ZHasl0R1WEarPE0PhQCWSXd/cAJiZVIUF8Co tbI7fzYJxfENH/LtNZ4ASlGf4Xsbb3CUy7OHwZXRpRbok7Rp/i5quR9W1OoCQyfZJ8Zm i6NiQWLuRSZYnNDN2P4lrGdGTZamW24aUU+9CirYxcdZpas6WaBsBwHdhMjlHpTI/i6n JiXT4i85BYLtmU2kiwjAhaqc0bMp6N9uWoyiYh0qjnGQwjSKksHJeblxUwhnQ1UB/ezr wNPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=bsHXEMxv; spf=pass (google.com: domain of alexander.levin@microsoft.com designates 104.47.38.112 as permitted sender) smtp.mailfrom=Alexander.Levin@microsoft.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=bsHXEMxv; spf=pass (google.com: domain of alexander.levin@microsoft.com designates 104.47.38.112 as permitted sender) smtp.mailfrom=Alexander.Levin@microsoft.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Johan Hovold , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 002/100] serdev: fix receive_buf return value when no callback Thread-Topic: [PATCH AUTOSEL for 4.14 002/100] serdev: fix receive_buf return value when no callback Thread-Index: AQHTmIb2nfnEeaRa/UWOlBHH7dzPbQ== Date: Sun, 28 Jan 2018 22:25:56 +0000 Message-ID: <20180128222547.7398-2-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1098;7:UTRNtcbRdqwFODpIm+gNhv11DdJXYyhR/Nye6g0k8/q0vRSLbzLovU+AeCsGFNoVizRKE4wMT98D33RpLGXee8VBJNeGC6m8s0fCOqjgXoyFyP1452gjbwGvxJjxvP03X/7zOAM6PU8AmVopP5jOB3JfucO0+1rViJuv2ftha0/RhnBGs2d/NyNjR4avpDNoyem+5IC36n0d6r+8+Dvnz6gppElFykK7nuLaCxCFHwuekb8CtC6tHW9RaoiJG2nV x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2fe8252e-dc56-4c16-590f-08d5669e1ac2 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1098; x-ms-traffictypediagnostic: MW2PR2101MB1098: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1098;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1098; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(54906003)(7736002)(66066001)(305945005)(316002)(72206003)(106356001)(2950100002)(478600001)(10290500003)(6506007)(97736004)(2906002)(105586002)(59450400001)(25786009)(107886003)(5250100002)(8676002)(110136005)(14454004)(5660300001)(2501003)(22452003)(2900100001)(81156014)(68736007)(6436002)(8936002)(53936002)(10090500001)(81166006)(99286004)(102836004)(3660700001)(36756003)(3280700002)(86612001)(3846002)(6116002)(86362001)(1076002)(4326008)(26005)(76176011)(6512007)(6486002)(186003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1098;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: AkgfcyKuO9eRES0O09W6HNNcOOdqQPj7bTKfesAcUXA8PvwE+cZMMzJlIP3Q3KMNfFWM6b0bgw+K8GVj5Wnnvg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fe8252e-dc56-4c16-590f-08d5669e1ac2 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:25:56.0557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590876817680626221?= X-GMAIL-MSGID: =?utf-8?q?1590876817680626221?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Johan Hovold [ Upstream commit fd00cf81a9a84776ba58e56bd042c726dcf75cf3 ] The receive_buf callback is supposed to return the number of bytes processed and should specifically not return a negative errno. Due to missing sanity checks in the serdev tty-port controller, a driver not providing a receive_buf callback could cause the flush_to_ldisc() worker to spin in a tight loop when the tty buffer pointers are incremented with -EINVAL (-22). The missing sanity checks have now been added to the tty-port controller, but let's fix up the serdev-controller helper as well. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- include/linux/serdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/serdev.h b/include/linux/serdev.h index e69402d4a8ae..d609e6dc5bad 100644 --- a/include/linux/serdev.h +++ b/include/linux/serdev.h @@ -184,7 +184,7 @@ static inline int serdev_controller_receive_buf(struct = serdev_controller *ctrl, struct serdev_device *serdev =3D ctrl->serdev; =20 if (!serdev || !serdev->ops->receive_buf) - return -EINVAL; + return 0; =20 return serdev->ops->receive_buf(serdev, data, count); } --=20 2.11.0