From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1452603-1517181518-2-14105366031683949041 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517181518; b=gsnK9N1xUQ6Kc2qRKGT/TM8UxiSd+2kl/XCcFh2qtrAM618 +/edqoeU1cRMqeV+A7/hOI7NAnpGS1a5XXlZxqPF6IpT1y+4SzItzmF6O25ceU2c mwKAUR6R3xwHiBK1FaBAxoBcaPTJfTVbHwJ+U8SXzbItjektaiICPl/Vu+MZKUVt x56jkgtstP0issvZFRjtxjIes/gXJ3ilWlcwNDdKvcTBwsbGqEfRZ39BLjYSzrOY tbSC/RsXd+eSzUWgrPnD/VpgsdVqpYPCXrPa7qt3ikJmQ8GTHbb52wYz3HKYfgzm g9g7D9sjxZbxXd4l+z4C8/RmaIZkDUfW+6ZuO3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517181518; bh=LK1mmY aWTUKNV+hyxLgcg0ETtWmRPfn2CmKzBV3/YZ0=; b=SG+Ii2VnoxEa73ibr2Iix8 Yrfa+pTfqogl5GUDTfVW4PbqgyUClq+0rPTELKMSVj3D9uYC27vAugdpo9czQPBs RyAht3wV/G7xQb7GqaD6GeqBMevCKxMvSFIwUghypiNDw+p16v1sUCrPnjcXMfsQ w9Umq+flCUWa9MAxJt7X1s/IpdmPfPKwCUznyRCxgTx0B+j/MY3d8YeUMLYrH0pE rlce54YgoZo7qA0YCrVNTv37Cf24wViXY8d7FGc/Lu6oBofuR5SO3/iik0nBFfTp gH6LvAzNRmOeb4jrA96r6aJ+TZ8F/o3Gf1FNJwC/q2Lw2wTDVlZehfbohku8QVeQ == ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=m+sO5XQi x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=m+sO5XQi x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754437AbeA1XSQ (ORCPT ); Sun, 28 Jan 2018 18:18:16 -0500 Received: from mail-bn3nam01on0107.outbound.protection.outlook.com ([104.47.33.107]:56768 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751611AbeA1W0E (ORCPT ); Sun, 28 Jan 2018 17:26:04 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Keerthy , Tony Lindgren , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 004/100] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function Thread-Topic: [PATCH AUTOSEL for 4.14 004/100] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function Thread-Index: AQHTmIb3L45mp7ZA1UKE+FJFx6XApQ== Date: Sun, 28 Jan 2018 22:25:57 +0000 Message-ID: <20180128222547.7398-4-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1098;7:JbW3kNWGY4jL+xFRvnZEOaGevd7ZO54lf6Q3t0xi+yEq4xN4XyvlDQWuUBa783O9gz9YjfK/D2YqIcO8Z+108IRQsSzPV2ViTa8CWNKsyFJQLgxyuBQ9jJqG6wDiIoUaa1Au/+wYhGnYkdk1co+v82+zkPCdDSktUbC5+7QHx60+I4S5CaJe/0kA1E+XUrQsDTy5xxUmLPS7I2qOp1KajO+xE3tLi1TgP4YLAYaPQxdOPbm12MdLVvSPq3bGONW2 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2b19a337-f1e1-4d53-675b-08d5669e1be3 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1098; x-ms-traffictypediagnostic: MW2PR2101MB1098: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(31051911155226)(89211679590171)(106291317490208); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1098;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1098; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(396003)(39860400002)(39380400002)(189003)(199004)(54906003)(7736002)(66066001)(305945005)(316002)(72206003)(106356001)(2950100002)(966005)(6666003)(478600001)(10290500003)(6506007)(97736004)(2906002)(105586002)(25786009)(107886003)(5250100002)(8676002)(110136005)(15760500003)(14454004)(5660300001)(2501003)(22452003)(2900100001)(81156014)(68736007)(6306002)(6436002)(8936002)(53936002)(10090500001)(81166006)(99286004)(102836004)(3660700001)(36756003)(3280700002)(86612001)(575784001)(3846002)(6116002)(86362001)(1076002)(4326008)(26005)(76176011)(6512007)(6486002)(186003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1098;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: yPtGGw80O8uVW22/tyCiXfHP3Zj3ConHcNrK5a+hufiKxx4jR2kx3LUqzCNdDFtqyp4Ff3PLaycCFKDG7q+AVw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b19a337-f1e1-4d53-675b-08d5669e1be3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:25:57.8100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1098 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Keerthy [ Upstream commit b6d6af7226465b6d11eac09d0be2ab78a4a9eb62 ] Referring TRM Am335X series: http://www.ti.com/lit/ug/spruh73p/spruh73p.pdf The LastPowerStateEntered bitfield is present only for PM_CEFUSE domain. This is not present in any of the other power domains. Hence remove the generic am33xx_pwrdm_read_prev_pwrst hook which wrongly reads the reserved bit fields for all the other power domains. Reading the reserved bits leads to wrongly interpreting the low power transitions for various power domains that do not have the LastPowerStateEntered field. The pm debug counters values are wrong currently as we are incrementing them based on the reserved bits. Signed-off-by: Keerthy Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/prm33xx.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm/mach-omap2/prm33xx.c b/arch/arm/mach-omap2/prm33xx.c index d2c5bcabdbeb..ebaf80d72a10 100644 --- a/arch/arm/mach-omap2/prm33xx.c +++ b/arch/arm/mach-omap2/prm33xx.c @@ -176,17 +176,6 @@ static int am33xx_pwrdm_read_pwrst(struct powerdomain = *pwrdm) return v; } =20 -static int am33xx_pwrdm_read_prev_pwrst(struct powerdomain *pwrdm) -{ - u32 v; - - v =3D am33xx_prm_read_reg(pwrdm->prcm_offs, pwrdm->pwrstst_offs); - v &=3D AM33XX_LASTPOWERSTATEENTERED_MASK; - v >>=3D AM33XX_LASTPOWERSTATEENTERED_SHIFT; - - return v; -} - static int am33xx_pwrdm_set_lowpwrstchange(struct powerdomain *pwrdm) { am33xx_prm_rmw_reg_bits(AM33XX_LOWPOWERSTATECHANGE_MASK, @@ -357,7 +346,6 @@ struct pwrdm_ops am33xx_pwrdm_operations =3D { .pwrdm_set_next_pwrst =3D am33xx_pwrdm_set_next_pwrst, .pwrdm_read_next_pwrst =3D am33xx_pwrdm_read_next_pwrst, .pwrdm_read_pwrst =3D am33xx_pwrdm_read_pwrst, - .pwrdm_read_prev_pwrst =3D am33xx_pwrdm_read_prev_pwrst, .pwrdm_set_logic_retst =3D am33xx_pwrdm_set_logic_retst, .pwrdm_read_logic_pwrst =3D am33xx_pwrdm_read_logic_pwrst, .pwrdm_read_logic_retst =3D am33xx_pwrdm_read_logic_retst, --=20 2.11.0