From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1175177-1517178433-2-6529952798773353317 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517178433; b=aV0gznNavCuyTh8TlSJC8/35hv0VBGJnQ+15QAJEz8vZXEv 8sFJW7ekAi/1xhawuTcSVU/amTyHLsysYNgV5r6PWtYFllLeytqYy6h6cqip+63Z Dpprx7B/qU40fhoRpR7VWYUy49xgARwSYpSJuZ3jTFB0S1/Fv/AkXPgJ5Q/+dv2N ZaEjbePV1CDgc8gNtJrTodSIyu2SJEO/BH/is+LVNGUP9kIEqNm7nXaFbE7Nrt8q vGmhTkukgsM0rUuzVrjovqvVZYpF5v0UbqVgSQjcyUY6hjmA0WeH4uTAv3Bo5dIg 8ivcjpKtQc+dF4dNpxxw9/W+vPxkCzwSoufozaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517178433; bh=VR88l6 qAtI6Okv7QBu9Zr5AfX1+aaWLcY5hZQCZBbEs=; b=EmgJB8skegmgTOS4MQ2DSB o3vaKVc4nZjSRw1HarhZ38FdrmMTN3J50mYs4w3HICpBHVP7+ULR7fBisK3Xz/7e jFA77R1TwqPluYDzoJ3Jl91fEWa9mNhFTASRiMqWmgQ+gJbQfFQCMS5ZssF1kLtL fyHupmrZGn24AY76FQ8xHxgUVYtrBfduBOb3rBUtDGtzErEkO65IIm+aZb97AHsq znP+mhNK8VeXQ54yWCkwPvCuym+HYeK6fgJeeg0xWOcSiYsY5ukJh8rGzbjnRgF6 T8aQs02ma0+kJ8QaO23DBC9tsT+KFLH2Xb2BTT6gjvoSw2CrpxIU2u8LlrHjk7ww == ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=IlhcKapM x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=IlhcKapM x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbeA1W1J (ORCPT ); Sun, 28 Jan 2018 17:27:09 -0500 Received: from mail-co1nam03on0111.outbound.protection.outlook.com ([104.47.40.111]:36928 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753355AbeA1W1D (ORCPT ); Sun, 28 Jan 2018 17:27:03 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Nogah Frankel , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 054/100] net_sched: red: Avoid devision by zero Thread-Topic: [PATCH AUTOSEL for 4.14 054/100] net_sched: red: Avoid devision by zero Thread-Index: AQHTmIcNyun+Fs+naU2HR3agIpA7fw== Date: Sun, 28 Jan 2018 22:26:33 +0000 Message-ID: <20180128222547.7398-54-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1034;7:3MPCclXz3FRXHHACkqG7KMIIHpu4ogKXHkpkSsojDQV0+MzcFicEKCdoxhNS0t9aA3Jxe+mDnCZZE1ogO5ZqLkfZonOby8bpOADKcVirzNpzvnl+FMauFIGVuHSpfawafNPmP/2MlSS6WrKBzlT94/RzXoAIpJAMn+RNHyxE66hU9OZACsLzr1yEP/RsNIu4W7Hz9ek0aYImMAcudKZrmkF1Rfno/GvJcqxct6Z7TmfWYKtKkyde3j7xLmE3Q1Vn x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8e67a548-e9fb-45a6-cd81-08d5669e3f4d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1034; x-ms-traffictypediagnostic: MW2PR2101MB1034: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1034;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1034; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(346002)(376002)(396003)(366004)(39380400002)(199004)(189003)(2906002)(2950100002)(26005)(1076002)(66066001)(6116002)(5660300001)(3846002)(186003)(316002)(22452003)(54906003)(110136005)(6666003)(86612001)(36756003)(6486002)(86362001)(53936002)(6436002)(6512007)(106356001)(8676002)(105586002)(305945005)(7736002)(68736007)(478600001)(81166006)(59450400001)(102836004)(76176011)(6506007)(72206003)(10290500003)(14454004)(2900100001)(3660700001)(99286004)(97736004)(81156014)(25786009)(8936002)(4326008)(5250100002)(3280700002)(2501003)(10090500001)(107886003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1034;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: m3adEJ0vHC8yxISTOoKUIAP33ckj1C9EQiSu2uX8jS6OyCOwVMaDcEwvU0eFe2j51Kz4EZhIWjzvBh5u6fmfPw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e67a548-e9fb-45a6-cd81-08d5669e3f4d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:33.9459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1034 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Nogah Frankel [ Upstream commit 5c472203421ab4f928aa1ae9e1dbcfdd80324148 ] Do not allow delta value to be zero since it is used as a divisor. Fixes: 8af2a218de38 ("sch_red: Adaptative RED AQM") Signed-off-by: Nogah Frankel Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- include/net/red.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/red.h b/include/net/red.h index 9a9347710701..5918f78d36a0 100644 --- a/include/net/red.h +++ b/include/net/red.h @@ -179,7 +179,7 @@ static inline void red_set_parms(struct red_parms *p, p->qth_max =3D qth_max << Wlog; p->Wlog =3D Wlog; p->Plog =3D Plog; - if (delta < 0) + if (delta <=3D 0) delta =3D 1; p->qth_delta =3D delta; if (!max_P) { --=20 2.11.0