From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1369136-1517180654-2-1649339557777907398 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517180654; b=m2uFFhPxXm6fG9HLVU06p7eUOCpSUAcJLdj2+3561QbAeda pb4aoYICDelHM7swHlRnGc0zzeXhcLE7/fQI+mp13c8bl90OpOk9cwINKL4votGX AkSZPxlLyFmk6DSCfcJlDJYhLkDLdCt5+dHtz59mjHHUy+VSU3YCIpkkpfUS5F1p cDgF8dqjPiRelcM9LQ3ErdQih2wU0W6POgHbUR1vlKh9BUxe6guAb6SC+3ggPwfD DeODmeVUhwfsK6A160c3wFT9qoOQsYLcV2HCjwaOW/lMYV/3+GUtLkJ/wUZF1N0O 2ajAC3YLWOMnEwDHHKoJ/LsE/oY+q9E6j5WIsMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517180654; bh=S47cBr I8y3zwY0MOzmcofwFkgHqRhtpYmntvlziJipM=; b=jNwtNdS+JHsdiw62Ok3nMs 3Z/+dI9N4u/VAMlqp9tO/N3Ru4wUlqGO6qNBRN1KmvT2iJMavg9VOiJFbRLNiYk/ HxbvP0TSh+PKt0Nxptxxi4xRoyl/JFa8FufHOKmeGg3YBnSP/MJMjzJfbd0N4qSK KJ8Ea3dkG10fjQyXhmTwLXWHwB97pjQnU7d6ZxbLO/VTLO7YbLopl26mwYmni5Q3 E/YO5aatDB7vazU1PN5146mfTtCCwnZaplyHCW824XkAjtpkiBK4wiv+8MzbrolF a9EahzIJUKYJYOVW/4vTbs1NuBX0Rvune9e/fOdwx17Z83mXnft4TbSQPUhzrhaw == ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=NekRrjRD x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=NekRrjRD x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbeA1XDn (ORCPT ); Sun, 28 Jan 2018 18:03:43 -0500 Received: from mail-bn3nam01on0128.outbound.protection.outlook.com ([104.47.33.128]:55858 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753463AbeA1W1k (ORCPT ); Sun, 28 Jan 2018 17:27:40 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Claudiu Manoil , Shaohui Xie , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 071/100] gianfar: Disable EEE autoneg by default Thread-Topic: [PATCH AUTOSEL for 4.14 071/100] gianfar: Disable EEE autoneg by default Thread-Index: AQHTmIcUeBjv7QSxpk2bfInKV2eJWQ== Date: Sun, 28 Jan 2018 22:26:45 +0000 Message-ID: <20180128222547.7398-71-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1018;6:AyhDq+poNE+CIO7RZXkVm3zbiC2TlWaHehNAaxyFWCILBSipm+57AwHvMC1c8+tH2OM2b+eUuxr7ov7MHHUlZGr48rzqoiXMzddIKEJSO3eOBl7G1/S9qMRW9gGj/CzngMMcc+HOzqsi8GNbEztwKfJGQA5feDoQJ03YilpxrhWX7Mfy/rExQTDX5mP/QPbKVDqANnlk+hcZmDtM+OBHp4XYDdiGNC95KQsGEt/lp17bh9EDts31km9ngWAZnJWIB1upJJ9QGLtSFZFAK9ak0tHmoVKjnjvGD+D8ioOhot3vY94DryVxSDrcFxxCdc7kd5DAiKx+2E42re8jTfdwFnlvoxgM08xWrBi7iAfQfXmekonpA+U/beDnIHfD5ts2;5:f92WhqVIFUpKlGXhHwHH5IGW1UzlWoLstGwkP3Xt5LYKFt8id4XjSSulicQEU7mBTwv8e11DlAQbf23GO7I7MGgspM8e9asXRYewslgMYWETU36snFPODzes9SBuqTD99VlwxVbA8EGldFV6TgCtLJj58UhlhAJQO8cl8oYszgY=;24:F16DM9WdZmi0BbbW8652zl4rvLvybjaN6XIo6RlI8XACqupXRB/VMUNfz+4LKlzAchzyGj0fmzj5/h6mTjdYutsFUorpUkyDBfcsNy9FsnU=;7:SdOYlC4r538RaFRbL7z8fEoMpwDc/6KX+Sx1zpTmXPFiOOa0fT3rlMPSc6iuaCLpsSwn5lTxxEq+Qz2oNnqIA0Re7hAkAPfIuuI7Cf0WCbvrU/jN8WzyOoUZHaBVbyNavRy8ETiWtugNjTLakNL4GV5lts3ALtihAOwxmq1+lvrJx3b4iJwvlfgbH/jioe4pwfMb5uc9Y7eyi0MdrjJ2nsG7XBCJqyPoaWbmq7GO5Ynyme2eJxnX6S9sXCdsU1lP x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8496707f-ee4b-4940-8771-08d5669e55b7 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1018; x-ms-traffictypediagnostic: MW2PR2101MB1018: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(185117386973197)(21532816269658); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1018;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1018; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39380400002)(39860400002)(366004)(346002)(376002)(199004)(189003)(53936002)(2501003)(6436002)(575784001)(86362001)(6486002)(5250100002)(26005)(102836004)(6512007)(76176011)(6116002)(2900100001)(3846002)(36756003)(305945005)(7736002)(316002)(3660700001)(22452003)(3280700002)(54906003)(110136005)(99286004)(8656006)(186003)(97736004)(1076002)(86612001)(81166006)(6666003)(2906002)(106356001)(14454004)(66066001)(4326008)(68736007)(5660300001)(25786009)(8936002)(10290500003)(81156014)(72206003)(107886003)(10090500001)(478600001)(2950100002)(105586002)(8676002)(6506007)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1018;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: mM3yxrnz9bNqf82XZxbXe4x/B2Mwizi0pllI8UsYKfKQyUjUg2NA2WO1dUTG+fme7lC/L9SMa2q1Y1aVE0AOSg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8496707f-ee4b-4940-8771-08d5669e55b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:45.2269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1018 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Claudiu Manoil [ Upstream commit b6b5e8a691185606dfffff3198c89e3b4fd9d4f6 ] This controller does not support EEE, but it may connect to a PHY which supports EEE and advertises EEE by default, while its link partner also advertises EEE. If this happens, the PHY enters low power mode when the traffic rate is low and causes packet loss. This patch disables EEE advertisement by default for any PHY that gianfar connects to, to prevent the above unwanted outcome. Signed-off-by: Shaohui Xie Tested-by: Yangbo Lu Signed-off-by: Claudiu Manoil Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/gianfar.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/etherne= t/freescale/gianfar.c index 81a73af0df31..7f837006bb6a 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1792,6 +1792,7 @@ static int init_phy(struct net_device *dev) GFAR_SUPPORTED_GBIT : 0; phy_interface_t interface; struct phy_device *phydev; + struct ethtool_eee edata; =20 priv->oldlink =3D 0; priv->oldspeed =3D 0; @@ -1816,6 +1817,10 @@ static int init_phy(struct net_device *dev) /* Add support for flow control, but don't advertise it by default */ phydev->supported |=3D (SUPPORTED_Pause | SUPPORTED_Asym_Pause); =20 + /* disable EEE autoneg, EEE not supported by eTSEC */ + memset(&edata, 0, sizeof(struct ethtool_eee)); + phy_ethtool_set_eee(phydev, &edata); + return 0; } =20 --=20 2.11.0