From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1369136-1517180553-2-6806210185177952449 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517180553; b=LWZ1iW3VpA55BPu9extIKalPvjRBYqdefcOPc6iZ6Qv/AQ3 f3QlL0HeExqDNl9SNGA5XbqvP1rTkYRXfgrkbY1K1VTQ0tT9EX6MPeOOlU6BVMLA g5IifllVLZPkw7rAgRSpm7ON1elCe07vli2dZhxWQh8OOSfQ8LktpGfkgHuM31ul zzFSzITbqkULdzvVgjH6JlCf0Gh8skgVrLmzMFEgZafNisoX0UX3W+V1WKalMXzs PVpRPqEKkZY46RlboknH/OC4uZewV/gKZbXphXnF+uAMpGNTXLu5CWLZSzChgbot 30ikl9i2iwU2ChWmCyIWls+xQ0ejW8XmQeDmG0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517180553; bh=MzGYU7 Xc0+X+CNeDHLnjf9C9pYx9g5jH92dYiuA65PE=; b=Oss2IjaJ/Y2sILOYQceIWb OYsQwWiklf9kHrACx0vccWf8qfLOaEvZuYDNoyalnIx69ur5y1ap5JiHaUseU+rC z2lpFJv2BwVg/2BwvoS/bCiehqjh8bIDSYhl/aMNnCNbEDaH0gMtG3VMrXJoWT6m tIQ28iqdliRdMUhYIffYs4WfDBV1pQoydSHYJppS/38mTpsguOS7tFVegycboGB+ JbU7v6O9umzOlERCEArAz5CVM7zgoeY21J1Jg7C7dDJbVST244mQMUySAUfQ13aj 0dJcoAcm6jfOLrMmzMIoTU9buz33xqtm/+KnVF5UdGhtOTCTWJa9CHdpJYWJ0+Ag == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=AvwTV+km x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=AvwTV+km x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753553AbeA1XCa (ORCPT ); Sun, 28 Jan 2018 18:02:30 -0500 Received: from mail-bn3nam01on0128.outbound.protection.outlook.com ([104.47.33.128]:55858 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753497AbeA1W1p (ORCPT ); Sun, 28 Jan 2018 17:27:45 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: "Gustavo A. R. Silva" , Vinod Koul , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 075/100] dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Thread-Topic: [PATCH AUTOSEL for 4.14 075/100] dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Thread-Index: AQHTmIcV4GIuacty9UGlbb4uNsQXBw== Date: Sun, 28 Jan 2018 22:26:47 +0000 Message-ID: <20180128222547.7398-75-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1018;6:shjGV0v0JN2vZPQv6byyalQGxX5GrQ/ElE2PHkRDIxMhNljVRSEJp35GSNxm00eZ+sbK18iDzUZ/J5e7plqZbQlYNWy3/SIppH7HSJ99YredfgGkIj/EPmaJeUDDdOksHLoPwg2/GVpWBbC7Gtv8JlCY2MKkCmXbc65odw1DDjWoNxM9IJj3pvrw7hbOLZedBKRo4AyyMw/NZo9Tl0aB5m6rWTL2nd2xRi5BBrKbkN8fxDuoivsxsTSfHYdc5/7cfJ44yJindlk+53vRL2blilMEsonHevix6TIoZ5+isWf43u7DBLjAvSS8lNIpnMFXWhLV2xmvvyItSyS++oeLI3TkgIdxhXa1dkeC2aCQl9IaVcRLl6iDMm0DuxE9ZCJa;5:G2YLejXzZjw7zLinWnZ7rQhc8uLHWIfGGCXYJ8VhSwv2WOAClLFnSvdKOb2HD9HpVBVSpygz0dLV1jXw5t6FyUnDVTzuEoQ5Vv7xVfG2nFpUAJvQBPbytCykWJgvE1GNqUkSRoyrqjUGlacENfyKVio4VHQyB9QHMW9c2deRK7U=;24:TlSm449KgFUdzUwxLBGcRd6GEwMFoo605aDiSXCRVrKV59YOPAPVeEoWjIC1RdvHiZXnt0Q6Gzb4vrPjaKqI3hREN9itSBeA7smT4szN//c=;7:fXFWUu1f4OnNTNbFRf2+XfDpmKhDbzmPqWiIZti3ycSyXWm3t1xVptK8agrSepmteRnDQRazxNnFEIDL152mfDTvlz3IL6Xpo1/ecibihLuXURwDDcMtq8tFeiF6YCDKauCh8twb4B2nGO37REsd0N9vIps7QM95GGeCszGlYwtr0N14CX4CQC52Nsm34LaIMv5RXSBrmSDIDbXT0RvimLX1YrKgalU5REEwgklSXb+dFRyueThc8Vby2D2Whetc x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e9e29ed8-dbc2-4fb5-2901-08d5669e5696 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1018; x-ms-traffictypediagnostic: MW2PR2101MB1018: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1018;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1018; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39380400002)(39860400002)(366004)(346002)(376002)(199004)(189003)(53936002)(2501003)(6436002)(86362001)(6486002)(5250100002)(26005)(102836004)(6512007)(59450400001)(76176011)(6116002)(2900100001)(3846002)(36756003)(305945005)(7736002)(316002)(3660700001)(22452003)(3280700002)(54906003)(110136005)(99286004)(186003)(97736004)(1076002)(86612001)(81166006)(6666003)(2906002)(106356001)(14454004)(66066001)(4326008)(68736007)(5660300001)(25786009)(8936002)(10290500003)(81156014)(72206003)(107886003)(10090500001)(478600001)(2950100002)(105586002)(8676002)(6506007)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1018;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: zIeSRLKZgf89N3bXMFEdIGx5yNJYhV75kDpSyXTN/2usWzsPGUOb0QY1z+su6wV9V0BzcHumWvzRMksMvn+4DA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9e29ed8-dbc2-4fb5-2901-08d5669e5696 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:47.9529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1018 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: "Gustavo A. R. Silva" [ Upstream commit 62a277d43d47e74972de44d33bd3763e31992414 ] _xt_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _xt_ has been null checked. This issue was detected with the help of Coccinelle. Fixes: 4483320e241c ("dmaengine: Use Pointer xt after NULL check.") Signed-off-by: Gustavo A. R. Silva Acked-by: Ludovic Desroches Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/at_hdmac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index fbab271b3bf9..a861b5b4d443 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -708,7 +708,7 @@ atc_prep_dma_interleaved(struct dma_chan *chan, unsigned long flags) { struct at_dma_chan *atchan =3D to_at_dma_chan(chan); - struct data_chunk *first =3D xt->sgl; + struct data_chunk *first; struct at_desc *desc =3D NULL; size_t xfer_count; unsigned int dwidth; @@ -720,6 +720,8 @@ atc_prep_dma_interleaved(struct dma_chan *chan, if (unlikely(!xt || xt->numf !=3D 1 || !xt->frame_size)) return NULL; =20 + first =3D xt->sgl; + dev_info(chan2dev(chan), "%s: src=3D%pad, dest=3D%pad, numf=3D%d, frame_size=3D%d, flags=3D0x%lx= \n", __func__, &xt->src_start, &xt->dst_start, xt->numf, --=20 2.11.0